Closed Bug 1289784 Opened 8 years ago Closed 8 years ago

Add a simple way to disable logging in breakpad

Categories

(Toolkit :: Crash Reporting, defect)

Product:
Toolkit
Component:
Crash Reporting
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED WORKSFORME

People

(Reporter: gsvelto, Unassigned)

References

Details

Currently breakpad's processor code logs a bunch of stuff to stdout when processing a minidump. This is mostly useless for a user that will never see those messages and very spammy for a developer who's simulating crashes.

Unfortunately the only way to disable logging is to define the BPLOG() macro as empty when building breakpad's sources which cannot be done in the build system. The fix in breakpad for this is trivial; if an empty BPLOG macro is provided it should handle it just like it handles an empty BPLOG() macro and turn off logging entirely.
I've worked around this in the past like:
https://dxr.mozilla.org/mozilla-central/source/toolkit/crashreporter/google-breakpad/src/client/mac/tests/testlogging.h

...but that's not fantastic, obviously. Breakpad's logging setup has never been great to work with.
Not a problem anymore, see bug 1280470 comment 17.
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.