128985 - nsHttpHandler::NewURI called too often

Status: RESOLVED FIXED

(Toolkit :: Form Manager, defect, P4)

Description

[Jeremy M. Dolan]

nsHttpHandler::NewURI is being called once for ever letter typed into the
username form at hotmail.com, and FOUR times for ever letter typed into the
password field.

After login, when on the hotmail 'Home', if I alt-tab to mozilla, with focus on
the page (not URL bar), nsHttpHandler::NewURI is called two to five times.

Comment 1

[Jeremy M. Dolan]

One more... unshading mozilla in sawfish (mozilla probably recieves an
uniconification event) calls NewURI fourteen times when logged in to hotmail. On
this page for instance, it's not called at all.

Comment 2

[Jeremy M. Dolan]

And... one more.. the select box on the compose page at hotmail calls newuri
nine times, and on that page only (that i've seen), the mouse entering and
exiting the page area calls newuri eight times each.

Comment 3

[Boris Zbarsky [:bzbarsky]]

OK.  Every single one of those calls comes through
nsCSSRendering::PaintBackgroundWithSC -- this takes the URL string from the
stylesheet, calls nsPresContext::LoadImage with it, and then
nsPresContext::LoadImage has to construct a URI object out of it.  Basically
anything causing a repaint will lead to lots of nsHttpHandler::NewURI calls as a
result.

David, should I just try to convert the struct to storing the nsIURI instead of
the string for urls?  Or do you want to do that as part of something else?

Comment 4

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

I actually started to do that, but didn't get anywhere near the point where the
changes would compile.  You can pick it up if you want -- I'll attach the
changes I had.

Comment 5

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: partial patch to convert to URI, etc.

Doing the image conversion stuff would require kicking off the image loads from
the rule structs, which would probably require some pres context changes.  That
might be better done as part of a separate patch -- perhaps it would be better
to just introduce an image type but make it also nsIURI* for now...

I also didn't get to changing the callers. :-)

Comment 6

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

This bug should be fixed by the checkin of bug 113173.