1289872 - 400,000 new warnings after landing bug 1275833 during linux64 debug testing

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Eric Rahm [:erahm]]

> 191842 WARNING: NS_ENSURE_TRUE(document) failed: file extensions/cookie/nsPermissionManager.cpp, line 2002

This warning [1] shows up in the following test suites:

>   6711 - desktop-test-linux64/debug-jsreftest-e10s-1 J1
>   6710 - desktop-test-linux64/debug-jsreftest-1 J1
>   6668 - desktop-test-linux64/debug-crashtest-e10s C
>   6657 - desktop-test-linux64/debug-crashtest C
>   6462 - desktop-test-linux64/debug-jsreftest-e10s-2 J2
>   6461 - desktop-test-linux64/debug-jsreftest-2 J2
>   5914 - desktop-test-linux64/debug-reftest-no-accel-1 Ru1
>   5914 - desktop-test-linux64/debug-reftest-1 R1
>   5912 - desktop-test-linux64/debug-reftest-no-accel-e10s-1 Ru1
>   5912 - desktop-test-linux64/debug-reftest-e10s-1 R1
>   5120 - desktop-test-linux64/debug-reftest-no-accel-6 Ru6
>   5120 - desktop-test-linux64/debug-reftest-6 R6
>   5068 - desktop-test-linux64/debug-reftest-no-accel-e10s-6 Ru6
>   5068 - desktop-test-linux64/debug-reftest-e10s-6 R6
>   4785 - desktop-test-linux64/debug-reftest-no-accel-3 Ru3
>   4785 - desktop-test-linux64/debug-reftest-3 R3
>   4766 - desktop-test-linux64/debug-reftest-no-accel-e10s-3 Ru3
>   4764 - desktop-test-linux64/debug-reftest-e10s-3 R3
>   4530 - desktop-test-linux64/debug-reftest-e10s-4 R4
>   4530 - desktop-test-linux64/debug-reftest-no-accel-e10s-4 Ru4
>   4526 - desktop-test-linux64/debug-reftest-no-accel-4 Ru4
>   4526 - desktop-test-linux64/debug-reftest-4 R4
>   4515 - desktop-test-linux64/debug-reftest-8 R8
>   4515 - desktop-test-linux64/debug-reftest-no-accel-e10s-8 Ru8
>   4515 - desktop-test-linux64/debug-reftest-e10s-8 R8
>   4515 - desktop-test-linux64/debug-reftest-no-accel-8 Ru8
>   4485 - desktop-test-linux64/debug-reftest-e10s-5 R5
>   4485 - desktop-test-linux64/debug-reftest-no-accel-e10s-5 Ru5
>   4433 - desktop-test-linux64/debug-reftest-no-accel-5 Ru5
>   4433 - desktop-test-linux64/debug-reftest-5 R5
>   4384 - desktop-test-linux64/debug-reftest-e10s-2 R2
>   4384 - desktop-test-linux64/debug-reftest-no-accel-e10s-2 Ru2
>   4374 - desktop-test-linux64/debug-reftest-no-accel-2 Ru2
>   4374 - desktop-test-linux64/debug-reftest-2 R2
>   4137 - desktop-test-linux64/debug-reftest-e10s-7 R7
>   4137 - desktop-test-linux64/debug-reftest-no-accel-e10s-7 Ru7
>   4135 - desktop-test-linux64/debug-reftest-no-accel-7 Ru7
>   4135 - desktop-test-linux64/debug-reftest-7 R7
>    295 - desktop-test-linux64/debug-firefox-ui-functional-local-e10s en-US
>    240 - desktop-test-linux64/debug-firefox-ui-functional-local en-US
>    234 - desktop-test-linux64/debug-firefox-ui-functional-remote-e10s en-US
>    208 - desktop-test-linux64/debug-firefox-ui-functional-remote en-US

It shows up in 46861 tests. A few of the most prevalent:

>    278 -        file:///home/worker/workspace/build/tests/reftest/tests/layout/reftests/selection/splitText-normalize.html == file:///home/worker/workspace/build/tests/reftest/tests/layout/reftests/selection/splitText-normalize-ref.html
>    278 - [e10s] file:///home/worker/workspace/build/tests/reftest/tests/layout/reftests/selection/splitText-normalize.html == file:///home/worker/workspace/build/tests/reftest/tests/layout/reftests/selection/splitText-normalize-ref.html
>    110 -        file:///home/worker/workspace/build/tests/reftest/tests/layout/reftests/selection/modify-range.html == file:///home/worker/workspace/build/tests/reftest/tests/layout/reftests/selection/modify-range-ref.html
>    110 - [e10s] file:///home/worker/workspace/build/tests/reftest/tests/layout/reftests/selection/modify-range.html == file:///home/worker/workspace/build/tests/reftest/tests/layout/reftests/selection/modify-range-ref.html
>     86 -        file:///home/worker/workspace/build/tests/reftest/tests/layout/reftests/svg/as-image/img-width-slice-2.html == file:///home/worker/workspace/build/tests/reftest/tests/layout/reftests/svg/as-image/img-width-slice-2-ref.html
>     86 - [e10s] file:///home/worker/workspace/build/tests/reftest/tests/layout/reftests/svg/as-image/img-height-slice-2.html == file:///home/worker/workspace/build/tests/reftest/tests/layout/reftests/svg/as-image/img-height-slice-2-ref.html
>     86 -        file:///home/worker/workspace/build/tests/reftest/tests/layout/reftests/svg/as-image/img-width-meet-2.html == file:///home/worker/workspace/build/tests/reftest/tests/layout/reftests/svg/as-image/img-width-meet-2-ref.html
>     86 - [e10s] file:///home/worker/workspace/build/tests/reftest/tests/layout/reftests/svg/as-image/img-novb-height-meet-1.html == file:///home/worker/workspace/build/tests/reftest/tests/layout/reftests/svg/as-image/img-novb-height-all-1-ref.html
>     86 -        file:///home/worker/workspace/build/tests/reftest/tests/layout/reftests/svg/as-image/img-widthAndHeight-meet-2.html == file:///home/worker/workspace/build/tests/reftest/tests/layout/reftests/svg/as-image/img-widthAndHeight-meet-2-ref.html
>     86 -        file:///home/worker/workspace/build/tests/reftest/tests/layout/reftests/svg/as-image/img-widthAndHeight-meet-1.html == file:///home/worker/workspace/build/tests/reftest/tests/layout/reftests/svg/as-image/img-widthAndHeight-meet-1-ref.html

[1] https://hg.mozilla.org/mozilla-central/annotate/fef429fba4c6/extensions/cookie/nsPermissionManager.cpp#l2002

Comment 1

[Eric Rahm [:erahm]]

The following also correlates, bisection points to bug 1280584.

> 191842 WARNING: NS_ENSURE_SUCCESS(rv, false) failed with result 0x80004002: file dom/base/nsDocument.cpp, line 5990

This warning [1] shows up in the following test suites:

>   6711 - desktop-test-linux64/debug-jsreftest-e10s-1 J1
>   6710 - desktop-test-linux64/debug-jsreftest-1 J1
>   6668 - desktop-test-linux64/debug-crashtest-e10s C
>   6657 - desktop-test-linux64/debug-crashtest C
>   6462 - desktop-test-linux64/debug-jsreftest-e10s-2 J2
>   6461 - desktop-test-linux64/debug-jsreftest-2 J2
>   5914 - desktop-test-linux64/debug-reftest-no-accel-1 Ru1
>   5914 - desktop-test-linux64/debug-reftest-1 R1
>   5912 - desktop-test-linux64/debug-reftest-no-accel-e10s-1 Ru1
>   5912 - desktop-test-linux64/debug-reftest-e10s-1 R1
>   5120 - desktop-test-linux64/debug-reftest-no-accel-6 Ru6
>   5120 - desktop-test-linux64/debug-reftest-6 R6
>   5068 - desktop-test-linux64/debug-reftest-no-accel-e10s-6 Ru6
>   5068 - desktop-test-linux64/debug-reftest-e10s-6 R6
>   4785 - desktop-test-linux64/debug-reftest-no-accel-3 Ru3
>   4785 - desktop-test-linux64/debug-reftest-3 R3
>   4766 - desktop-test-linux64/debug-reftest-no-accel-e10s-3 Ru3
>   4764 - desktop-test-linux64/debug-reftest-e10s-3 R3
>   4530 - desktop-test-linux64/debug-reftest-e10s-4 R4
>   4530 - desktop-test-linux64/debug-reftest-no-accel-e10s-4 Ru4
>   4526 - desktop-test-linux64/debug-reftest-no-accel-4 Ru4
>   4526 - desktop-test-linux64/debug-reftest-4 R4
>   4515 - desktop-test-linux64/debug-reftest-8 R8
>   4515 - desktop-test-linux64/debug-reftest-no-accel-e10s-8 Ru8
>   4515 - desktop-test-linux64/debug-reftest-e10s-8 R8
>   4515 - desktop-test-linux64/debug-reftest-no-accel-8 Ru8
>   4485 - desktop-test-linux64/debug-reftest-e10s-5 R5
>   4485 - desktop-test-linux64/debug-reftest-no-accel-e10s-5 Ru5
>   4433 - desktop-test-linux64/debug-reftest-no-accel-5 Ru5
>   4433 - desktop-test-linux64/debug-reftest-5 R5
>   4384 - desktop-test-linux64/debug-reftest-e10s-2 R2
>   4384 - desktop-test-linux64/debug-reftest-no-accel-e10s-2 Ru2
>   4374 - desktop-test-linux64/debug-reftest-no-accel-2 Ru2
>   4374 - desktop-test-linux64/debug-reftest-2 R2
>   4137 - desktop-test-linux64/debug-reftest-e10s-7 R7
>   4137 - desktop-test-linux64/debug-reftest-no-accel-e10s-7 Ru7
>   4135 - desktop-test-linux64/debug-reftest-no-accel-7 Ru7
>   4135 - desktop-test-linux64/debug-reftest-7 R7
>    295 - desktop-test-linux64/debug-firefox-ui-functional-local-e10s en-US
>    240 - desktop-test-linux64/debug-firefox-ui-functional-local en-US
>    234 - desktop-test-linux64/debug-firefox-ui-functional-remote-e10s en-US
>    208 - desktop-test-linux64/debug-firefox-ui-functional-remote en-US

It shows up in 46861 tests. A few of the most prevalent:

>    278 -        file:///home/worker/workspace/build/tests/reftest/tests/layout/reftests/selection/splitText-normalize.html == file:///home/worker/workspace/build/tests/reftest/tests/layout/reftests/selection/splitText-normalize-ref.html
>    278 - [e10s] file:///home/worker/workspace/build/tests/reftest/tests/layout/reftests/selection/splitText-normalize.html == file:///home/worker/workspace/build/tests/reftest/tests/layout/reftests/selection/splitText-normalize-ref.html
>    110 -        file:///home/worker/workspace/build/tests/reftest/tests/layout/reftests/selection/modify-range.html == file:///home/worker/workspace/build/tests/reftest/tests/layout/reftests/selection/modify-range-ref.html
>    110 - [e10s] file:///home/worker/workspace/build/tests/reftest/tests/layout/reftests/selection/modify-range.html == file:///home/worker/workspace/build/tests/reftest/tests/layout/reftests/selection/modify-range-ref.html
>     86 -        file:///home/worker/workspace/build/tests/reftest/tests/layout/reftests/svg/as-image/img-width-slice-2.html == file:///home/worker/workspace/build/tests/reftest/tests/layout/reftests/svg/as-image/img-width-slice-2-ref.html
>     86 - [e10s] file:///home/worker/workspace/build/tests/reftest/tests/layout/reftests/svg/as-image/img-height-slice-2.html == file:///home/worker/workspace/build/tests/reftest/tests/layout/reftests/svg/as-image/img-height-slice-2-ref.html
>     86 -        file:///home/worker/workspace/build/tests/reftest/tests/layout/reftests/svg/as-image/img-width-meet-2.html == file:///home/worker/workspace/build/tests/reftest/tests/layout/reftests/svg/as-image/img-width-meet-2-ref.html
>     86 - [e10s] file:///home/worker/workspace/build/tests/reftest/tests/layout/reftests/svg/as-image/img-novb-height-meet-1.html == file:///home/worker/workspace/build/tests/reftest/tests/layout/reftests/svg/as-image/img-novb-height-all-1-ref.html
>     86 -        file:///home/worker/workspace/build/tests/reftest/tests/layout/reftests/svg/as-image/img-widthAndHeight-meet-2.html == file:///home/worker/workspace/build/tests/reftest/tests/layout/reftests/svg/as-image/img-widthAndHeight-meet-2-ref.html
>     86 -        file:///home/worker/workspace/build/tests/reftest/tests/layout/reftests/svg/as-image/img-widthAndHeight-meet-1.html == file:///home/worker/workspace/build/tests/reftest/tests/layout/reftests/svg/as-image/img-widthAndHeight-meet-1-ref.html

[1] https://hg.mozilla.org/mozilla-central/annotate/fef429fba4c6/dom/base/nsDocument.cpp#l5990

Comment 2

[:Gijs (he/him)]

This is very unfortunate. I would normally dig at this until I figured it out, but I'm handicapped by the fact that I'm going on PTO tomorrow, it's now very late here in Europe, I didn't have a debug build, and I don't know the code in question - it's pretty far removed from the URI code which I changed. :-(

It's odd these warnings apparently don't show up in mochitests or other marionette tests. They do show up (at least for me locally) when just using ./mach run on a debug build.

The backtrace from a reftest looks like this:

* thread #1: tid = 0x15de9c, 0x0000000103316fe6 XUL`nsPermissionManager::TestPermissionFromWindow(this=0x00000001156a25b0, aWindow=<unavailable>, aType="moz-extremely-unstable-and-will-change-webcomponents", aPermission=0x00007fff5fbfe1c8) + 134 at nsPermissionManager.cpp:2002, queue = 'com.apple.main-thread', stop reason = breakpoint 2.1
  * frame #0: 0x0000000103316fe6 XUL`nsPermissionManager::TestPermissionFromWindow(this=0x00000001156a25b0, aWindow=<unavailable>, aType="moz-extremely-unstable-and-will-change-webcomponents", aPermission=0x00007fff5fbfe1c8) + 134 at nsPermissionManager.cpp:2002
    frame #1: 0x0000000103a91ef5 XUL`nsDocument::IsWebComponentsEnabled(aCx=<unavailable>, aObject=<unavailable>) + 437 at nsDocument.cpp:5988
    frame #2: 0x0000000103984852 XUL`mozilla::dom::CustomElementsRegistry::IsCustomElementsEnabled(aCx=<unavailable>, aObject=<unavailable>) + 98 at CustomElementsRegistry.cpp:29
    frame #3: 0x0000000104975d8a XUL`bool mozilla::dom::DefinePrefable<JSPropertySpec const>(JSContext*, JS::Handle<JSObject*>, mozilla::dom::Prefable<JSPropertySpec const> const*) [inlined] mozilla::dom::PrefableDisablers::isEnabled(this=<unavailable>) const + 118 at DOMJSClass.h:126
    frame #4: 0x0000000104975d14 XUL`bool mozilla::dom::DefinePrefable<JSPropertySpec const>(JSContext*, JS::Handle<JSObject*>, mozilla::dom::Prefable<JSPropertySpec const> const*) [inlined] mozilla::dom::Prefable<JSPropertySpec const>::isEnabled(obj=<unavailable>) const + 9 at DOMJSClass.h:154
    frame #5: 0x0000000104975d0b XUL`bool mozilla::dom::DefinePrefable<JSPropertySpec const>(cx=0x000000011161c000, obj=Handle<JSObject *> @ r14, props=<unavailable>) + 43 at BindingUtils.cpp:626
    frame #6: 0x000000010495c75c XUL`mozilla::dom::DefineProperties(cx=0x000000011161c000, obj=Handle<JSObject *> @ r14, properties=0x0000000108c3e020, chromeOnlyProperties=0x0000000108c3f820) + 108 at BindingUtils.cpp:877
    frame #7: 0x00000001044bfdde XUL`mozilla::dom::WindowBinding::Wrap(aCx=0x000000011161c000, aObject=0x0000000115ab5000, aCache=0x0000000115ab5000, aOptions=<unavailable>, aPrincipal=<unavailable>, aInitStandardClasses=<unavailable>, aReflector=<unavailable>) + 206 at WindowBinding.cpp:14852
    frame #8: 0x0000000103921219 XUL`nsGlobalWindow::SetNewDocument(nsIDocument*, nsISupports*, bool) [inlined] CreateNativeGlobalForInner(aCx=<unavailable>, aURI=0x0000000115c59fb0, aPrincipal=<unavailable>) + 35 at nsGlobalWindow.cpp:2576
    frame #9: 0x00000001039211f6 XUL`nsGlobalWindow::SetNewDocument(this=0x0000000115ab6000, aDocument=0x0000000115c75000, aState=0x0000000115ab5000, aForceReuseInnerWindow=false) + 3222 at nsGlobalWindow.cpp:2791
    frame #10: 0x0000000105a907ad XUL`nsDocumentViewer::InitInternal(this=0x000000011496bda0, aParentWidget=<unavailable>, aState=0x0000000000000000, aBounds=<unavailable>, aDoCreation=true, aNeedMakeCX=true, aForceSetNewDocument=<unavailable>) + 1805 at nsDocumentViewer.cpp:873
    frame #11: 0x0000000105a90098 XUL`nsDocumentViewer::Init(this=<unavailable>, aParentWidget=<unavailable>, aBounds=<unavailable>) + 40 at nsDocumentViewer.cpp:617
    frame #12: 0x0000000105f94acb XUL`nsDocShell::SetupNewViewer(this=<unavailable>, aNewViewer=<unavailable>) + 2379 at nsDocShell.cpp:9373
    frame #13: 0x0000000105f94030 XUL`nsDocShell::Embed(this=0x0000000115ab5800, aContentViewer=0x000000011496bda0, aCommand=<unavailable>, aExtraInfo=<unavailable>) + 32 at nsDocShell.cpp:7234
    frame #14: 0x0000000105f9abd6 XUL`nsDocShell::CreateAboutBlankContentViewer(this=0x0000000115ab5800, aPrincipal=<unavailable>, aBaseURI=<unavailable>, aTryToSaveOldPresentation=<unavailable>) + 1366 at nsDocShell.cpp:8093
    frame #15: 0x000000010601de36 XUL`nsWebShellWindow::Initialize(this=<unavailable>, aParent=0x0000000107758977, aOpener=<unavailable>, aUrl=0x0000000115a7b900, aInitialWidth=<unavailable>, aInitialHeight=<unavailable>, aIsHiddenWindow=<unavailable>, aOpeningTab=<unavailable>, widgetInitData=<unavailable>) + 2198 at nsWebShellWindow.cpp:218
    frame #16: 0x000000010601b277 XUL`nsAppShellService::JustCreateTopWindow(this=<unavailable>, aParent=0x0000000000000000, aUrl=0x0000000115a7b900, aChromeMask=0, aInitialWidth=1, aInitialHeight=1, aIsHiddenWindow=<unavailable>, aOpeningTab=<unavailable>, aResult=<unavailable>) + 935 at nsAppShellService.cpp:738
    frame #17: 0x000000010601ad09 XUL`nsAppShellService::CreateHiddenWindowHelper(this=<unavailable>, aIsPrivate=<unavailable>) + 441 at nsAppShellService.cpp:136
    frame #18: 0x0000000106325bd9 XUL`nsAppStartup::CreateHiddenWindow(this=<unavailable>) + 89 at nsAppStartup.cpp:248
    frame #19: 0x00000001063b2627 XUL`XREMain::XRE_mainRun(this=0x00007fff5fbfeff0) + 4855 at nsAppRunner.cpp:4178
    frame #20: 0x00000001063b32d3 XUL`XREMain::XRE_main(this=0x00007fff5fbfeff0, argc=<unavailable>, argv=<unavailable>, aAppData=<unavailable>) + 659 at nsAppRunner.cpp:4383
    frame #21: 0x00000001063b37f9 XUL`::XRE_main(argc=<unavailable>, argv=<unavailable>, aAppData=<unavailable>, aFlags=<unavailable>) + 217 at nsAppRunner.cpp:4474
    frame #22: 0x00000001000021ae firefox`main [inlined] do_main(argc=5, argv=0x00007fff5fbff650, envp=<unavailable>) + 614 at nsBrowserApp.cpp:247
    frame #23: 0x0000000100001f48 firefox`main(argc=5, argv=<unavailable>, envp=<unavailable>) + 1320 at nsBrowserApp.cpp:380
    frame #24: 0x0000000100001a14 firefox`start + 52

This is the browser trying to create the hidden window and load about blank in it, and that seems to be unhappy. Frankly, I'm very surprised that we even start successfully without one (or maybe we do create it? I dunno...). I also don't know *why* it's unhappy.

Comment 3

[:Gijs (he/him)]

(In reply to :Gijs Kruitbosch (Gone July 28 - Aug 11) from comment #2)
> This is very unfortunate. I would normally dig at this until I figured it
> out, but I'm handicapped by the fact that I'm going on PTO tomorrow, it's
> now very late here in Europe, I didn't have a debug build, and I don't know
> the code in question - it's pretty far removed from the URI code which I
> changed. :-(
> 
> It's odd these warnings apparently don't show up in mochitests or other
> marionette tests. They do show up (at least for me locally) when just using
> ./mach run on a debug build.
> 
> The backtrace from a reftest looks like this:
> 
> * thread #1: tid = 0x15de9c, 0x0000000103316fe6
> XUL`nsPermissionManager::TestPermissionFromWindow(this=0x00000001156a25b0,
> aWindow=<unavailable>,
> aType="moz-extremely-unstable-and-will-change-webcomponents",
> aPermission=0x00007fff5fbfe1c8) + 134 at nsPermissionManager.cpp:2002, queue
> = 'com.apple.main-thread', stop reason = breakpoint 2.1
>   * frame #0: 0x0000000103316fe6
> XUL`nsPermissionManager::TestPermissionFromWindow(this=0x00000001156a25b0,
> aWindow=<unavailable>,
> aType="moz-extremely-unstable-and-will-change-webcomponents",
> aPermission=0x00007fff5fbfe1c8) + 134 at nsPermissionManager.cpp:2002
>     frame #1: 0x0000000103a91ef5
> XUL`nsDocument::IsWebComponentsEnabled(aCx=<unavailable>,
> aObject=<unavailable>) + 437 at nsDocument.cpp:5988
>     frame #2: 0x0000000103984852
> XUL`mozilla::dom::CustomElementsRegistry::
> IsCustomElementsEnabled(aCx=<unavailable>, aObject=<unavailable>) + 98 at
> CustomElementsRegistry.cpp:29
>     frame #3: 0x0000000104975d8a XUL`bool
> mozilla::dom::DefinePrefable<JSPropertySpec const>(JSContext*,
> JS::Handle<JSObject*>, mozilla::dom::Prefable<JSPropertySpec const> const*)
> [inlined] mozilla::dom::PrefableDisablers::isEnabled(this=<unavailable>)
> const + 118 at DOMJSClass.h:126
>     frame #4: 0x0000000104975d14 XUL`bool
> mozilla::dom::DefinePrefable<JSPropertySpec const>(JSContext*,
> JS::Handle<JSObject*>, mozilla::dom::Prefable<JSPropertySpec const> const*)
> [inlined] mozilla::dom::Prefable<JSPropertySpec
> const>::isEnabled(obj=<unavailable>) const + 9 at DOMJSClass.h:154
>     frame #5: 0x0000000104975d0b XUL`bool
> mozilla::dom::DefinePrefable<JSPropertySpec const>(cx=0x000000011161c000,
> obj=Handle<JSObject *> @ r14, props=<unavailable>) + 43 at
> BindingUtils.cpp:626
>     frame #6: 0x000000010495c75c
> XUL`mozilla::dom::DefineProperties(cx=0x000000011161c000,
> obj=Handle<JSObject *> @ r14, properties=0x0000000108c3e020,
> chromeOnlyProperties=0x0000000108c3f820) + 108 at BindingUtils.cpp:877
>     frame #7: 0x00000001044bfdde
> XUL`mozilla::dom::WindowBinding::Wrap(aCx=0x000000011161c000,
> aObject=0x0000000115ab5000, aCache=0x0000000115ab5000,
> aOptions=<unavailable>, aPrincipal=<unavailable>,
> aInitStandardClasses=<unavailable>, aReflector=<unavailable>) + 206 at
> WindowBinding.cpp:14852
>     frame #8: 0x0000000103921219
> XUL`nsGlobalWindow::SetNewDocument(nsIDocument*, nsISupports*, bool)
> [inlined] CreateNativeGlobalForInner(aCx=<unavailable>,
> aURI=0x0000000115c59fb0, aPrincipal=<unavailable>) + 35 at
> nsGlobalWindow.cpp:2576
>     frame #9: 0x00000001039211f6
> XUL`nsGlobalWindow::SetNewDocument(this=0x0000000115ab6000,
> aDocument=0x0000000115c75000, aState=0x0000000115ab5000,
> aForceReuseInnerWindow=false) + 3222 at nsGlobalWindow.cpp:2791
>     frame #10: 0x0000000105a907ad
> XUL`nsDocumentViewer::InitInternal(this=0x000000011496bda0,
> aParentWidget=<unavailable>, aState=0x0000000000000000,
> aBounds=<unavailable>, aDoCreation=true, aNeedMakeCX=true,
> aForceSetNewDocument=<unavailable>) + 1805 at nsDocumentViewer.cpp:873
>     frame #11: 0x0000000105a90098
> XUL`nsDocumentViewer::Init(this=<unavailable>, aParentWidget=<unavailable>,
> aBounds=<unavailable>) + 40 at nsDocumentViewer.cpp:617
>     frame #12: 0x0000000105f94acb
> XUL`nsDocShell::SetupNewViewer(this=<unavailable>, aNewViewer=<unavailable>)
> + 2379 at nsDocShell.cpp:9373
>     frame #13: 0x0000000105f94030
> XUL`nsDocShell::Embed(this=0x0000000115ab5800,
> aContentViewer=0x000000011496bda0, aCommand=<unavailable>,
> aExtraInfo=<unavailable>) + 32 at nsDocShell.cpp:7234
>     frame #14: 0x0000000105f9abd6
> XUL`nsDocShell::CreateAboutBlankContentViewer(this=0x0000000115ab5800,
> aPrincipal=<unavailable>, aBaseURI=<unavailable>,
> aTryToSaveOldPresentation=<unavailable>) + 1366 at nsDocShell.cpp:8093
>     frame #15: 0x000000010601de36
> XUL`nsWebShellWindow::Initialize(this=<unavailable>,
> aParent=0x0000000107758977, aOpener=<unavailable>, aUrl=0x0000000115a7b900,
> aInitialWidth=<unavailable>, aInitialHeight=<unavailable>,
> aIsHiddenWindow=<unavailable>, aOpeningTab=<unavailable>,
> widgetInitData=<unavailable>) + 2198 at nsWebShellWindow.cpp:218
>     frame #16: 0x000000010601b277
> XUL`nsAppShellService::JustCreateTopWindow(this=<unavailable>,
> aParent=0x0000000000000000, aUrl=0x0000000115a7b900, aChromeMask=0,
> aInitialWidth=1, aInitialHeight=1, aIsHiddenWindow=<unavailable>,
> aOpeningTab=<unavailable>, aResult=<unavailable>) + 935 at
> nsAppShellService.cpp:738
>     frame #17: 0x000000010601ad09
> XUL`nsAppShellService::CreateHiddenWindowHelper(this=<unavailable>,
> aIsPrivate=<unavailable>) + 441 at nsAppShellService.cpp:136
>     frame #18: 0x0000000106325bd9
> XUL`nsAppStartup::CreateHiddenWindow(this=<unavailable>) + 89 at
> nsAppStartup.cpp:248
>     frame #19: 0x00000001063b2627
> XUL`XREMain::XRE_mainRun(this=0x00007fff5fbfeff0) + 4855 at
> nsAppRunner.cpp:4178
>     frame #20: 0x00000001063b32d3
> XUL`XREMain::XRE_main(this=0x00007fff5fbfeff0, argc=<unavailable>,
> argv=<unavailable>, aAppData=<unavailable>) + 659 at nsAppRunner.cpp:4383
>     frame #21: 0x00000001063b37f9 XUL`::XRE_main(argc=<unavailable>,
> argv=<unavailable>, aAppData=<unavailable>, aFlags=<unavailable>) + 217 at
> nsAppRunner.cpp:4474
>     frame #22: 0x00000001000021ae firefox`main [inlined] do_main(argc=5,
> argv=0x00007fff5fbff650, envp=<unavailable>) + 614 at nsBrowserApp.cpp:247
>     frame #23: 0x0000000100001f48 firefox`main(argc=5, argv=<unavailable>,
> envp=<unavailable>) + 1320 at nsBrowserApp.cpp:380
>     frame #24: 0x0000000100001a14 firefox`start + 52
> 
> This is the browser trying to create the hidden window and load about blank
> in it, and that seems to be unhappy. Frankly, I'm very surprised that we
> even start successfully without one (or maybe we do create it? I dunno...).
> I also don't know *why* it's unhappy.

Uh, ignore this, because apparently this copy of inbound was old and didn't even have my changes yet. So one useful thing: AFAICT the warning was already happening before the patch, just less frequent. erahm, is that right?

Comment 4

[:Gijs (he/him)]

erahm and I looked at this and we now think this wasn't caused by bug 1280584. Not yet sure what the real culprit is, so leaving ni.

Comment 5

[Eric Rahm [:erahm]]

So we think it's something else in https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=ceb63dec9267e9bb62f5e5e1f4c9d32d3ac1fbac&tochange=8c361c7cc683e24771a973f2b822fd84605db0ed

I'll try to repro locally.

Comment 6

[Eric Rahm [:erahm]]

Looks like there's a bug in mozregression, the real range is: https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=ceb63dec9267e9bb62f5e5e1f4c9d32d3ac1fbac&tochange=c571462b1ff5e0d4661b9df4135b03febc81162c

It looks like the previous push is the culprit.

Comment 7

[Eric Rahm [:erahm]]

Alright things got out of whack because a few builds didn't have tests (giving a false sense of 0 warnings).

I manually bisected, bug 1275833 is the lucky winner. John can you take a look at this?

Comment 8

[John Dai[:jdai]]

Sorry for the log spam, I will take a loot at it.

Comment 9

[John Dai[:jdai]]

Attachment: Bug 1289872 - Fixed the warning log spam due to bug 1275833.

Try result: https://treeherder.mozilla.org/#/jobs?repo=try&revision=59d937a43e633b6921a12556d8945ef8586d2283

Comment 10

[John Dai[:jdai]]

Comment on attachment 8775536 [details] [diff] [review]
Bug 1289872 - Fixed the warning log spam due to bug 1275833.

Hi William,
I saw nsDocument::IsWebComponentsEnabled has some code relative to B2G [1] and those code cause this issue. I am not sure should we still keep those code. Therefore, I checked "dom.webcomponents.enabled" preference directly in CustomElementsRegistry::IsCustomElementsEnabled.

[1]https://dxr.mozilla.org/mozilla-central/source/dom/base/nsDocument.cpp#5973-5990

Comment 11

[William Chen [:wchen]]

Comment on attachment 8775536 [details] [diff] [review]
Bug 1289872 - Fixed the warning log spam due to bug 1275833.

We should also revert the changes to registerElement in the webidl [1] so that b2g consumers of the old API with the special web components permission don't break.

[1] https://dxr.mozilla.org/mozilla-central/rev/ffac2798999c5b84f1b4605a1280994bb665a406/dom/webidl/Document.webidl#274

Comment 12

[John Dai[:jdai]]

(In reply to William Chen [:wchen] from comment #11)
> Comment on attachment 8775536 [details] [diff] [review]
> Bug 1289872 - Fixed the warning log spam due to bug 1275833.
> 
> We should also revert the changes to registerElement in the webidl [1] so
> that b2g consumers of the old API with the special web components permission
> don't break.
> 
File bug 1292125 for this.
> [1]
> https://dxr.mozilla.org/mozilla-central/rev/
> ffac2798999c5b84f1b4605a1280994bb665a406/dom/webidl/Document.webidl#274

Comment 13

[John Dai[:jdai]]

Attachment: Bug 1289872 - Fixed the warning log spam due to bug 1275833. r=wchen

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/6fc40ec6d00d
Fixed the warning log spams due to bug 1275833. r=wchen

Comment 15

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/6fc40ec6d00d