Closed Bug 1289873 Opened 5 years ago Closed 5 years ago
_FAILURE _ID only reported if successful
58 bytes, text/x-review-board-request
I'm not seeing any failure id being sent into telemetry. Looking closer at the code, the patch only covers the success path. It doesn't cover the failure path: https://hg.mozilla.org/mozilla-central/annotate/78dd94ba93c77d0bba45f8e4525947629a305a41/gfx/layers/ipc/CompositorBridgeParent.cpp#l1623
Have a quick patch for the failure path, but may need to investigate other paths (the one you linked) as not sure if return failure ids at initialization will cover that path in CompositorBridgeParent::AllocPLayerTransactionParent as well.
Review commit: https://reviewboard.mozilla.org/r/67470/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/67470/
Actually, the failure path you posted will be covered in this patch, as the layer manager is created after the compositor, and so any compositor failures should already be reported at that point. See CompositorBridgeParent::InitializeLayerManager(const nsTArray<LayersBackend>& aBackendHints)
Comment on attachment 8775299 [details] Bug 1289873 - correction made for compositing failure ids in failure path not showing up https://reviewboard.mozilla.org/r/67470/#review64638 Looks good. Just change the commit message to reflect the change and not the bug description.
Attachment #8775299 - Flags: review?(bgirard) → review+
Comment on attachment 8775299 [details] Bug 1289873 - correction made for compositing failure ids in failure path not showing up Review request updated; see interdiff: https://reviewboard.mozilla.org/r/67470/diff/1-2/
Attachment #8775299 - Attachment description: Bug 1289873 - *_COMPOSITING_FAILURE_ID only reported if successful → Bug 1289873 - correction made for compositing failure ids in failure path not showing up
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/autoland/rev/cf46248f894f correction made for compositing failure ids in failure path not showing up r=BenWa
sorry ignore try push.
You need to log in before you can comment on or make changes to this bug.