1289892 - Crash in java.lang.NullPointerException: Attempt to get length of null array at org.mozilla.gecko.telemetry.stores.TelemetryJSONFilePingStore.maybePrunePings(TelemetryJSONFilePingStore.java)

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[(inactive) Jim Chen [:jchen] [:darchons]]

This bug was filed from the Socorro interface and is 
report bp-166863cb-a2f1-4756-a351-0dbb32160727.
=============================================================

Low volume crash first seen in the 20160719030224 nightly. The cause is storeDir.listFiles returning null in TelemetryJSONFilePingStore.maybePrunePings. This could indicate an IO error or that the directory does not exist. In either case, I think we should simply return here, so the fix is a simple null-check.

Comment 1

[Tobias (:Tobbi) Markus]

Related: bug 1289006

Fix should be the same. Taking this.

Comment 2

[Tobias (:Tobbi) Markus]

Attachment: fix

Comment 3

[Tobias (:Tobbi) Markus]

Attachment: patch

Who is the best person to request review for this?

Comment 4

[:Grisha Kruglov]

Comment on attachment 8775828 [details] [diff] [review]
patch

Review of attachment 8775828 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/fx-team/rev/f3f6e368b95e
Return gracefully if listFiles returns null. r=gkruglov

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/f3f6e368b95e

Comment 7

[Jan Henning [:JanH]]

I've also seen this as an OOM crash.