Closed Bug 1289916 Opened 3 years ago Closed 3 years ago

Don't trigger a tree traversal in ProcessPendingRestyles if the tree isn't dirty

Categories

(Core :: CSS Parsing and Computation, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla50
Tracking Status
firefox50 --- fixed

People

(Reporter: bholley, Assigned: bholley)

References

Details

Attachments

(1 file)

This is causing assertion failures with the new machinery. I've got a patch.
It's possible (and in fact, desirable) for the restyle hints to all evaluate
to 0, which means the tree stays clean even though the map was non-empty.
Attachment #8775322 - Flags: review?(ealvarez)
Comment on attachment 8775322 [details] [diff] [review]
Check tree dirtiness in ProcessPendingRestyles before triggering traversal. v1

Review of attachment 8775322 [details] [diff] [review]:
-----------------------------------------------------------------

Hmmm... Indeed, good catch.
Attachment #8775322 - Flags: review?(ealvarez) → review+
Pushed by bholley@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/f8669df3b3de
Check tree dirtiness in ProcessPendingRestyles before triggering traversal. r=emilio
https://hg.mozilla.org/mozilla-central/rev/f8669df3b3de
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
Blocks: stylo-incremental
No longer blocks: stylo
You need to log in before you can comment on or make changes to this bug.