1289984 - Fix nICEr compiler warnings on Win

Status: RESOLVED FIXED

(Core :: WebRTC: Networking, defect, P2)

Comment 1

[Nils Ohlmeier [:drno]]

Attachment: Bug 1289984: fix Windows compiler warnings.

Review commit: https://reviewboard.mozilla.org/r/67610/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/67610/

Comment 2

[Nils Ohlmeier [:drno]]

For reference the build outputs on treeherder currently show this:

13:52:05     INFO -  transport_addr.c
13:52:05     INFO -  Warning: C4013 in c:\builds\moz2_slave\m-in-w64-000000000000000000000\build\src\media\mtransport\third_party\nICEr\src\net\transport_addr.c: 'inet_ntop' undefined; assuming extern returning int
13:52:05     INFO -  c:/builds/moz2_slave/m-in-w64-000000000000000000000/build/src/media/mtransport/third_party/nICEr/src/net/transport_addr.c(75): warning C4013: 'inet_ntop' undefined; assuming extern returning int
13:52:05     INFO -  Warning: C4013 in c:\builds\moz2_slave\m-in-w64-000000000000000000000\build\src\media\mtransport\third_party\nICEr\src\net\transport_addr.c: 'inet_pton' undefined; assuming extern returning int
13:52:05     INFO -  c:/builds/moz2_slave/m-in-w64-000000000000000000000/build/src/media/mtransport/third_party/nICEr/src/net/transport_addr.c(222): warning C4013: 'inet_pton' undefined; assuming extern returning int
13:52:05     INFO -  Warning: C4047 in c:\builds\moz2_slave\m-in-w64-000000000000000000000\build\src\media\mtransport\third_party\nICEr\src\net\transport_addr.c: '=': 'const char *' differs in levels of indirection from 'int'
13:52:05     INFO -  c:/builds/moz2_slave/m-in-w64-000000000000000000000/build/src/media/mtransport/third_party/nICEr/src/net/transport_addr.c(266): warning C4047: '=': 'const char *' differs in levels of indirection from 'int'
13:52:05     INFO -  Warning: C4047 in c:\builds\moz2_slave\m-in-w64-000000000000000000000\build\src\media\mtransport\third_party\nICEr\src\net\transport_addr.c: '=': 'const char *' differs in levels of indirection from 'int'
13:52:05     INFO -  c:/builds/moz2_slave/m-in-w64-000000000000000000000/build/src/media/mtransport/third_party/nICEr/src/net/transport_addr.c(269): warning C4047: '=': 'const char *' differs in levels of indirection from 'int'
13:52:05     INFO -  c:/mozilla-build/python27/python2.7.EXE c:/builds/moz2_slave/m-in-w64-000000000000000000000/build/src/sccache/sccache.py c:/builds/moz2_slave/m-in-w64-000000000000000000000/build/src/vs2015u2/VC/bin/amd64/cl.EXE -Foecho_control_mobile_impl.obj -c   -DNDEBUG -DTRIMMED=1 -DWIN32 -D_WINDOWS -DNOMINMAX -DPSAPI_VERSION=1 -D_CRT_RAND_S -DCERT_CHAIN_PARA_HAS_EXTRA_FIELDS -DWIN32_LEAN_AND_MEAN -D_ATL_NO_OPENGL -D_HAS_EXCEPTIONS=0 -D_SECURE_ATL -DCHROMIUM_BUILD -DTOOLKIT_VIEWS=1 -DUSE_LIBJPEG_TURBO=1 -DENABLE_ONE_CLICK_SIGNIN -DENABLE_REMOTING=1 -DENABLE_WEBRTC=1 -DENABLE_CONFIGURATION_POLICY -DENABLE_INPUT_SPEECH -DENABLE_NOTIFICATIONS -DENABLE_GPU=1 -DENABLE_EGLIMAGE=1 -DUSE_SKIA=1 -D__STD_C -D_CRT_SECURE_NO_DEPRECATE -D_SCL_SECURE_NO_DEPRECATE -DENABLE_TASK_MANAGER=1 -DENABLE_WEB_INTENTS=1 -DENABLE_EXTENSIONS=1 -DENABLE_PLUGIN_INSTALLATION=1 -DENABLE_PROTECTOR_SERVICE=1 -DENABLE_SESSION_SERVICE=1 -DENABLE_THEMES=1 -DENABLE_BACKGROUND=1 -DENABLE_AUTOMATION=1 -DENABLE_PRINTING=1 -DENABLE_CAPTIVE_PORTAL_DETECTION=1 -DWEBRTC_MOZILLA_BUILD -DEXPAT_RELATIVE_PATH -DWEBRTC_WIN -DWEBRTC_AEC_DEBUG_DUMP -DWEBRTC_NS_FLOAT -D__STDC_FORMAT_MACROS -DNVALGRIND -DDYNAMIC_ANNOTATIONS_ENABLED=0 -DUNICODE -D_UNICODE -DSTATIC_EXPORTABLE_JS_API -DMOZILLA_INTERNAL_API -DIMPL_LIBXUL -Ic:/builds/moz2_slave/m-in-w64-000000000000000000000/build/src/media/webrtc/trunk/webrtc/modules -Ic:/builds/moz2_slave/m-in-w64-000000000000000000000/build/src/obj-firefox/media/webrtc/trunk/webrtc/modules/modules_audio_processing -Ic:/builds/moz2_slave/m-in-w64-000000000000000000000/build/src/media/webrtc/trunk -Ic:/builds/moz2_slave/m-in-w64-000000000000000000000/build/src/media/webrtc/trunk/webrtc/common_audio/resampler/include -Ic:/builds/moz2_slave/m-in-w64-000000000000000000000/build/src/media/webrtc/trunk/webrtc/common_audio/signal_processing/include -Ic:/builds/moz2_slave/m-in-w64-000000000000000000000/build/src/media/webrtc/trunk/webrtc/common_audio/vad/include -Ic:/builds/moz2_slave/m-in-w64-000000000000000000000/build/src/obj-firefox/ipc/ipdl/_ipdlheaders -Ic:/builds/moz2_slave/m-in-w64-000000000000000000000/build/src/ipc/chromium/src -Ic:/builds/moz2_slave/m-in-w64-000000000000000000000/build/src/ipc/glue -Ic:/builds/moz2_slave/m-in-w64-000000000000000000000/build/src/obj-firefox/dist/include     -MD -FI c:/builds/moz2_slave/m-in-w64-000000000000000000000/build/src/obj-firefox/mozilla-config.h -DMOZILLA_CLIENT -deps.deps/echo_control_mobile_impl.obj.pp  -TP -nologo -wd5026 -wd5027 -Zc:sizedDealloc- -Zc:threadSafeInit- -wd4091 -wd4577 -D_HAS_EXCEPTIONS=0 -W3 -Gy -Zc:inline -FS -wd4251 -wd4244 -wd4267 -wd4345 -wd4351 -wd4800 -wd4819 -wd4595 -we4553 -GR-  -Z7 -O1 -Oi -Oy-    c:/builds/moz2_slave/m-in-w64-000000000000000000000/build/src/media/webrtc/trunk/webrtc/modules/audio_processing/echo_control_mobile_impl.cc
13:52:05     INFO -  transport_addr_reg.c
13:52:05     INFO -  Warning: C4013 in c:\builds\moz2_slave\m-in-w64-000000000000000000000\build\src\media\mtransport\third_party\nICEr\src\net\transport_addr_reg.c: 'inet_ntop' undefined; assuming extern returning int
13:52:05     INFO -  c:/builds/moz2_slave/m-in-w64-000000000000000000000/build/src/media/mtransport/third_party/nICEr/src/net/transport_addr_reg.c(153): warning C4013: 'inet_ntop' undefined; assuming extern returning int
13:52:05     INFO -  Warning: C4996 in c:\builds\moz2_slave\m-in-w64-000000000000000000000\build\src\media\mtransport\third_party\nICEr\src\net\transport_addr_reg.c: 'inet_ntoa': Use inet_ntop() or InetNtop() instead or define _WINSOCK_DEPRECATED_NO_WARNINGS to disable deprecated API warnings
13:52:05     INFO -  c:/builds/moz2_slave/m-in-w64-000000000000000000000/build/src/media/mtransport/third_party/nICEr/src/net/transport_addr_reg.c(140): warning C4996: 'inet_ntoa': Use inet_ntop() or InetNtop() instead or define _WINSOCK_DEPRECATED_NO_WARNINGS to disable deprecated API warnings
13:52:05     INFO -  c:\builds\moz2_slave\m-in-w64-000000000000000000000\build\src\vs2015u2\SDK\Include\um\winsock2.h(1844): note: see declaration of 'inet_ntoa'

Comment 3

[Byron Campen [:bwc]]

Comment on attachment 8775428 [details]
Bug 1289984: fix Windows compiler warnings.

https://reviewboard.mozilla.org/r/67610/#review64794

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ca06c0afd540
fix Windows compiler warnings. r=bwc

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/ca06c0afd540