Closed Bug 1289989 Opened 3 years ago Closed 3 years ago

Remove VS2013 workaround for VP8 test crash

Categories

(Core :: Audio/Video: Recording, defect)

Product:
Core
Component:
Audio/Video: Recording
Type:
defect
Priority:
Not set

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla50
Tracking Flags:
Tracking Status
firefox50 --- fixed

People

(Reporter: cpeterson, Assigned: cpeterson)

References

Details

Attachments

(1 file)

vs2013-dom-media.patch
1.44 KB, patch
u459114
: review+
Details | Diff | Splinter Review 
We no longer support building with VS2013 (bug 1186064) so this #ifdef can be removed.
Attachment #8775446 - Flags: review?(cku)
Comment on attachment 8775446 [details] [diff] [review]
vs2013-dom-media.patch

Review of attachment 8775446 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM
Attachment #8775446 - Flags: review?(cku) → review+
Thanks!
Pushed by cpeterson@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/312322a8f076
Remove VS2013 workaround for VP8 test crash. r=cku
https://hg.mozilla.org/mozilla-central/rev/312322a8f076
Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox50: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
> We no longer support building with VS2013 (bug 1186064) so this #ifdef can be removed.

For the record, the ifdef was trying to prevent the test from running on any VS from 2013 or later. I expect that the crash would also occur with VS2015 had we not backed out the -Gw changes in bug 1018402 comment 48 (I guess I should have also backed out this ifdef at that time).

In any case, bug 1018402 comment 50 makes me hopeful that we can re-enable -Gw and still avoid this crash.
You need to log in before you can comment on or make changes to this bug.