1290032 - [WebGL2] pass gl.getSamplerParameter() in gl-object-get-calls.html

Status: RESOLVED FIXED

(Core :: Graphics: CanvasWebGL, defect)

Description

[Jerry Shih[:jerry] (UTC+8) (inactive)]

Gecko doesn't return null value when we have invalidEnum.

Comment 1

[Jerry Shih[:jerry] (UTC+8) (inactive)]

Attachment: return null for InvalidEnum. v1

Comment 2

[Jerry Shih[:jerry] (UTC+8) (inactive)]

Comment on attachment 8775502 [details] [diff] [review]
return null for InvalidEnum. v1

Review of attachment 8775502 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/canvas/WebGL2ContextSamplers.cpp
@@ +205,5 @@
>  {
>      if (IsContextLost())
>          return;
>  
> +    retval.set(JS::NullValue());

I am also curious about the return value for context lost.

If it is also a nullValue(), a lot of functions need to be updated.

@@ +211,4 @@
>      if (!sampler || sampler->IsDeleted())
>          return ErrorInvalidOperation("getSamplerParameter: invalid sampler");
>  
>      if (!ValidateSamplerParameterName(pname, "getSamplerParameter"))

ValidateSamplerParameterName() only setup InvalidEnum(), but it doesn't set the retval to NullValue().

Comment 3

[Kelsey Gilbert [:jgilbert]]

Comment on attachment 8775502 [details] [diff] [review]
return null for InvalidEnum. v1

Review of attachment 8775502 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/canvas/WebGL2ContextSamplers.cpp
@@ +205,5 @@
>  {
>      if (IsContextLost())
>          return;
>  
> +    retval.set(JS::NullValue());

It's nullValue. Put this before IsContextLost.

Comment 4

[Jerry Shih[:jerry] (UTC+8) (inactive)]

Attachment: return null for InvalidEnum. v2

Comment 5

[Jerry Shih[:jerry] (UTC+8) (inactive)]

Just a simple fix.
Please land the attachment 8775819 [details] [diff] [review] to m-c.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/85b1e566b5b8
return null for InvalidEnum. r=jgilbert

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/85b1e566b5b8