Closed
Bug 1290049
Opened 8 years ago
Closed 8 years ago
Intermittent test_peerConnection_restartIceLocalAndRemoteRollback.html | iceconnectionstate event 'connected' matches expected state 'checking' - got "connected", expected "checking"
Categories
(Core :: WebRTC: Networking, defect, P3)
Core
WebRTC: Networking
Tracking
()
RESOLVED
FIXED
mozilla52
Tracking | Status | |
---|---|---|
firefox49 | --- | unaffected |
firefox50 | --- | fixed |
firefox51 | --- | fixed |
firefox52 | --- | fixed |
People
(Reporter: intermittent-bug-filer, Assigned: mjf)
Details
(Keywords: intermittent-failure)
Attachments
(1 file)
58 bytes,
text/x-review-board-request
|
bwc
:
review+
ritu
:
approval-mozilla-aurora+
ritu
:
approval-mozilla-beta+
|
Details |
Filed by: tomcat [at] mozilla.com https://treeherder.mozilla.org/logviewer.html#?job_id=4498734&repo=mozilla-central https://queue.taskcluster.net/v1/task/HE3zYYvUSqyeRKK9SIAk2g/runs/0/artifacts/public%2Flogs%2Flive_backing.log
Updated•8 years ago
|
Rank: 35
Priority: -- → P3
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Updated•8 years ago
|
status-firefox49:
--- → unaffected
status-firefox50:
--- → affected
status-firefox51:
--- → affected
Comment hidden (Intermittent Failures Robot) |
Updated•8 years ago
|
status-firefox52:
--- → affected
Comment 7•8 years ago
|
||
Looks to me like our tests are to strict in expecting connected->checking->connected and don't allow connected->connected. Michael, Byron: what do you guys think about making the tests less strict on this one?
Component: WebRTC → WebRTC: Networking
Flags: needinfo?(mfroman)
Flags: needinfo?(docfaraday)
Comment hidden (Intermittent Failures Robot) |
Assignee | ||
Comment 9•8 years ago
|
||
Nils: Are you thinking that we're missing the transition through checking?
Flags: needinfo?(mfroman)
Comment 10•8 years ago
|
||
I am not sure how we are ending up missing a transition to checking, it really should happen every time.
Flags: needinfo?(docfaraday)
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Assignee | ||
Comment 13•8 years ago
|
||
I captured this in rr on Friday in the midst of looking at another bug.
Assignee: nobody → mfroman
Comment hidden (mozreview-request) |
Assignee | ||
Updated•8 years ago
|
Attachment #8800334 -
Flags: review?(docfaraday)
Comment 15•8 years ago
|
||
mozreview-review |
Comment on attachment 8800334 [details] Bug 1290049 - only process ice connection state change if new state differs from old state. https://reviewboard.mozilla.org/r/85254/#review83856 Hmm. So I think I see the thing you're trying to prevent here (we do an ICE restart, and then rollback before the new ctx makes it to checking, which causes us to fire a duplicate state change for whatever state the original ctx was in). And I think this change will prevent that. But I think it will also eat state changes; suppose that the original ctx changes state before we rollback. We may need to put the filtering closer to JS-land.
Attachment #8800334 -
Flags: review?(docfaraday) → review-
Comment hidden (mozreview-request) |
Comment 17•8 years ago
|
||
mozreview-review |
Comment on attachment 8800334 [details] Bug 1290049 - only process ice connection state change if new state differs from old state. https://reviewboard.mozilla.org/r/85254/#review84582
Attachment #8800334 -
Flags: review?(docfaraday) → review+
Comment hidden (mozreview-request) |
Assignee | ||
Updated•8 years ago
|
Keywords: checkin-needed
Comment 19•8 years ago
|
||
Pushed by ryanvm@gmail.com: https://hg.mozilla.org/integration/autoland/rev/65e0762afc23 only process ice connection state change if new state differs from old state. r=bwc
Keywords: checkin-needed
Comment hidden (Intermittent Failures Robot) |
Comment 21•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/65e0762afc23
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
Comment 22•8 years ago
|
||
Please request Aurora/Beta approval on this when you get a chance.
Flags: needinfo?(mfroman)
Assignee | ||
Comment 23•8 years ago
|
||
Comment on attachment 8800334 [details] Bug 1290049 - only process ice connection state change if new state differs from old state. Approval Request Comment [Feature/regressing bug #]: Bug 906986 - Support ICE restart [User impact if declined]: When rolling back an ICE restart, if the next ICE context has not had time to progress from the init state, after rollback a second connection status with state 'connected' is sent. This second 'connected' state causes orange in the tree. [Describe test coverage new/current, TreeHerder]: (current) test_peerConnection_restartIceLocalAndRemoteRollback.html [Risks and why]: Very little risk here. Before ICE restart was implemented we were already filtering connection state updates when there was no change, and this patch ensures that rolling back an ICE restart matches that behavior. [String/UUID change made/needed]: none
Flags: needinfo?(mfroman)
Attachment #8800334 -
Flags: approval-mozilla-beta?
Attachment #8800334 -
Flags: approval-mozilla-aurora?
Comment on attachment 8800334 [details] Bug 1290049 - only process ice connection state change if new state differs from old state. Fixes an intermittent, patch seems low risk, Aurora51+, Beta50+
Attachment #8800334 -
Flags: approval-mozilla-beta?
Attachment #8800334 -
Flags: approval-mozilla-beta+
Attachment #8800334 -
Flags: approval-mozilla-aurora?
Attachment #8800334 -
Flags: approval-mozilla-aurora+
Comment 25•8 years ago
|
||
bugherder uplift |
https://hg.mozilla.org/releases/mozilla-aurora/rev/1dff984fccd0
Comment 26•8 years ago
|
||
bugherder uplift |
https://hg.mozilla.org/releases/mozilla-beta/rev/8ebdcfa6203a
You need to log in
before you can comment on or make changes to this bug.
Description
•