1290061 - stylo: Mark nsStyleUnion/Unit fields as unsafe and private for bindgen

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect)

Description

[Manish Goregaokar [:manishearth]]

Last step in the safe interface for nsStyleCoord (https://github.com/servo/servo/pull/12521)

Comment 1

[Manish Goregaokar [:manishearth]]

Attachment: Bug 1290061 - stylo: Mark nsStyleUnion/Unit fields as unsafe and private for bindgen;

Review commit: https://reviewboard.mozilla.org/r/67728/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/67728/

Comment 2

[Manish Goregaokar [:manishearth]]

Depends on https://github.com/servo/servo/pull/12631, this should preferably land first

Comment 3

[Bobby Holley (:bholley)]

Comment on attachment 8775549 [details]
Bug 1290061 - stylo: Mark nsStyleUnion/Unit fields as unsafe and private for bindgen;

https://reviewboard.mozilla.org/r/67728/#review64838

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c70e8c8d0a79
stylo: Mark nsStyleUnion/Unit fields as unsafe and private for bindgen; r=bholley

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/c70e8c8d0a79