User can unintentionally enter private browsing with top tabs

VERIFIED FIXED

Status

()

VERIFIED FIXED
2 years ago
2 years ago

People

(Reporter: nalcock, Assigned: nalcock)

Tracking

unspecified
Other
iOS

Firefox Tracking Flags

(fxios-v6.0 verified, fxios6.0+)

Details

Attachments

(1 attachment)

48 bytes, text/x-github-pull-request
bnicholson
: review+
Details | Review | Splinter Review
(Assignee)

Description

2 years ago
Start with a single normal tab and no private tabs, on iPad. Switch to private mode. Switch back to normal mode. Close the current tab.

Expected behaviour: a new normal tab will be opened in the tab's place.

Actual behaviour: the browser will switch to private browsing mode, on the tab the user had previously opened.
(Assignee)

Comment 1

2 years ago
Created attachment 8775613 [details] [review]
Pull request
Assignee: nobody → nalcock
Attachment #8775613 - Flags: review?(bnicholson)
tracking-fxios: --- → ?
Attachment #8775613 - Flags: review?(bnicholson) → review+
tracking-fxios: ? → 5.1+
Whiteboard: [needsuplift]
tracking-fxios: 5.1+ → 6.0+
(Assignee)

Comment 2

2 years ago
https://github.com/mozilla/firefox-ios/commit/cdff9ba5e3f05dce5cdedf7e473f71121804d7a5
Status: NEW → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
Whiteboard: [needsuplift]
This issue is not reproducible on latest master (acc25e6d9)
Status: RESOLVED → VERIFIED
status-fxios-v6.0: --- → verified
You need to log in before you can comment on or make changes to this bug.