Closed Bug 1290220 Opened 4 years ago Closed 4 years ago

Switch the simulators over to js::Thread instead of PRThread

Categories

(Core :: JavaScript Engine, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla51
Tracking Status
firefox51 --- fixed

People

(Reporter: fitzgen, Assigned: fitzgen)

References

Details

Attachments

(1 file, 2 obsolete files)

These checks aren't exactly redundant with js::Mutex/PTHREAD_MUTEX_ERRORCHECK,
like the other lockHolder members, since there are random assertions that the
lock has any holder in various places. These should probably be re-written to
pass around LockGuard references, but that would be a lot more churn than I want
to do at the moment.
Try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=e0d41de5799c
Assignee: nobody → nfitzgerald
Blocks: 956899
Status: NEW → ASSIGNED
Attachment #8775697 - Attachment is obsolete: true
Attachment #8775697 - Flags: review?(terrence)
Comment on attachment 8775708 [details] [diff] [review]
Switch the simulators over to js::Thread instead of PRThread

Review of attachment 8775708 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/jit/arm/Simulator-arm.cpp
@@ -1130,5 @@
>  
> -#ifdef DEBUG
> -    cacheLockHolder_ = nullptr;
> -#endif
> -    redirection_ = nullptr;

D'oh... did not mean to remove the `redirection_ = nullptr;` here...
Attachment #8775708 - Flags: review?(terrence)
Sorry for all the churn...
Attachment #8775808 - Flags: review?(terrence)
Attachment #8775708 - Attachment is obsolete: true
Pushed by nfitzgerald@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/e834808ca14b
Switch the simulators over to js::Thread instead of PRThread; r=terrence
Attachment #8775808 - Flags: review?(terrence) → review+
Pushed by nfitzgerald@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/3ec6476e6d89
Switch the simulators over to js::Thread instead of PRThread; r=terrence
Flags: needinfo?(nfitzgerald)
https://hg.mozilla.org/mozilla-central/rev/3ec6476e6d89
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla51
Depends on: 1291349
You need to log in before you can comment on or make changes to this bug.