1290220 - Switch the simulators over to js::Thread instead of PRThread

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

These checks aren't exactly redundant with js::Mutex/PTHREAD_MUTEX_ERRORCHECK,
like the other lockHolder members, since there are random assertions that the
lock has any holder in various places. These should probably be re-written to
pass around LockGuard references, but that would be a lot more churn than I want
to do at the moment.

Comment 1

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Attachment: Switch the simulators over to js::Thread instead of PRThread

Comment 2

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=e0d41de5799c

Comment 3

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Attachment: Switch the simulators over to js::Thread instead of PRThread

Comment 4

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=f0d562241fab

Comment 5

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Comment on attachment 8775708 [details] [diff] [review]
Switch the simulators over to js::Thread instead of PRThread

Review of attachment 8775708 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/jit/arm/Simulator-arm.cpp
@@ -1130,5 @@
>  
> -#ifdef DEBUG
> -    cacheLockHolder_ = nullptr;
> -#endif
> -    redirection_ = nullptr;

D'oh... did not mean to remove the `redirection_ = nullptr;` here...

Comment 6

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Attachment: Switch the simulators over to js::Thread instead of PRThread

Sorry for all the churn...

Comment 7

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

New try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=1887fac87561

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/e834808ca14b
Switch the simulators over to js::Thread instead of PRThread; r=terrence

Comment 9

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

This or something else from the push appears to have turned 10.10 debug cpp tests permared: https://treeherder.mozilla.org/logviewer.html#?job_id=33028238&repo=mozilla-inbound
https://hg.mozilla.org/integration/mozilla-inbound/rev/a86df78500c3

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/3ec6476e6d89
Switch the simulators over to js::Thread instead of PRThread; r=terrence

Comment 11

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/3ec6476e6d89