1290229 - Bug 1285541 broke sndio backend

Status: RESOLVED FIXED

(Core :: Audio/Video: cubeb, defect, P2)

Description

[Landry Breuil (:gaston)]

12:33.45 /home/dusk/home/buildslave-amd64/mozilla-central-amd64/build/media/libcubeb/src/cubeb_sndio.c:293:4: error: use of undeclared identifier 'latency'

sadface... and pretty sure its going to migrate to aurora as is..

Comment 1

[Landry Breuil (:gaston)]

So what replaces latency, latency_frames everywhere ?

Comment 2

[Landry Breuil (:gaston)]

Or it looks like this was a bulldozer search'n'replace here..https://hg.mozilla.org/integration/mozilla-inbound/rev/0173124d4d31#l13.47 latency_ms was a method parameter.

Comment 3

[Landry Breuil (:gaston)]

> static int
> sndio_get_min_latency(cubeb * ctx, cubeb_stream_params params, uint32_t * latency_ms)
> {
>   // XXX Not yet implemented.
>-  *latency = 2048;
>+  *latency_ms = 2048;

This fixes the build issue.. dunno if that's the 'best' fix.

Comment 4

[Paul Adenot (:padenot)]

yeah, latency_frames everywhere, sorry about that.

Comment 5

[Landry Breuil (:gaston)]

Attachment: bug-1290229

Comment 6

[Paul Adenot (:padenot)]

gaston, I'll upstream this. We're in the process of uplifting our copy of cubeb from upstream.

Comment 7

[Paul Adenot (:padenot)]

https://github.com/kinetiknz/cubeb/pull/140

Comment 8

[Landry Breuil (:gaston)]

So should i set c-n and it lands in m-i or should wait for a uplift from github ?

Comment 9

[Paul Adenot (:padenot)]

We'll land it for you today on m-c with all other cubeb changes.

Comment 10

[Landry Breuil (:gaston)]

Fixed by https://hg.mozilla.org/integration/mozilla-inbound/rev/87ebc9fdddee / https://hg.mozilla.org/mozilla-central/rev/87ebc9fdddee / bug 1290425