1290290 - 1,500 instances of "'NS_FAILED(res)'" emitted from editor/libeditor/EditorBase.cpp during linux64 debug testing

Status: RESOLVED WORKSFORME

(Core :: DOM: Editor, defect, P5)

Description

[Eric Rahm [:erahm]]

> 1382 WARNING: 'NS_FAILED(res)', file editor/libeditor/EditorBase.cpp, line 663

This warning [1] shows up in the following test suites:

>    200 - desktop-test-linux64/debug-mochitest-8 8
>    151 - desktop-test-linux64/debug-crashtest-e10s C
>    140 - desktop-test-linux64/debug-crashtest C
>    120 - desktop-test-linux64/debug-mochitest-e10s-8 8
>     85 - desktop-test-linux64/debug-mochitest-e10s-9 9
>     64 - desktop-test-linux64/debug-mochitest-clipboard cl
>     58 - desktop-test-linux64/debug-reftest-no-accel-e10s-8 Ru8
>     58 - desktop-test-linux64/debug-reftest-e10s-8 R8
>     57 - desktop-test-linux64/debug-reftest-no-accel-8 Ru8
>     57 - desktop-test-linux64/debug-reftest-8 R8
>     57 - desktop-test-linux64/debug-mochitest-jetpack JP
>     56 - desktop-test-linux64/debug-mochitest-clipboard-e10s cl
>     24 - desktop-test-linux64/debug-reftest-3 R3
>     24 - desktop-test-linux64/debug-reftest-no-accel-3 Ru3
>     23 - desktop-test-linux64/debug-mochitest-chrome-2 c2
>     23 - desktop-test-linux64/debug-reftest-e10s-3 R3
>     23 - desktop-test-linux64/debug-reftest-no-accel-e10s-3 Ru3
>     21 - desktop-test-linux64/debug-mochitest-a11y a11y
>     15 - desktop-test-linux64/debug-mochitest-3 3
>     15 - desktop-test-linux64/debug-mochitest-e10s-3 3
>     13 - desktop-test-linux64/debug-mochitest-chrome-3 c3
>      6 - desktop-test-linux64/debug-mochitest-9 9
>      6 - desktop-test-linux64/debug-reftest-e10s-4 R4
>      6 - desktop-test-linux64/debug-reftest-no-accel-e10s-4 Ru4
>      6 - desktop-test-linux64/debug-reftest-no-accel-4 Ru4
>      6 - desktop-test-linux64/debug-reftest-4 R4
>      5 - desktop-test-linux64/debug-mochitest-2 2
>      5 - desktop-test-linux64/debug-mochitest-browser-chrome-e10s-3 bc3
>      4 - desktop-test-linux64/debug-mochitest-chrome-1 c1
>      4 - desktop-test-linux64/debug-mochitest-browser-chrome-e10s-6 bc6
>      4 - desktop-test-linux64/debug-mochitest-browser-chrome-4 bc4
>      4 - desktop-test-linux64/debug-mochitest-1 1
>      4 - desktop-test-linux64/debug-mochitest-e10s-1 1
>      3 - desktop-test-linux64/debug-reftest-no-accel-2 Ru2
>      3 - desktop-test-linux64/debug-reftest-e10s-2 R2
>      3 - desktop-test-linux64/debug-reftest-no-accel-e10s-2 Ru2
>      3 - desktop-test-linux64/debug-mochitest-browser-chrome-6 bc6
>      3 - desktop-test-linux64/debug-reftest-2 R2
>      3 - desktop-test-linux64/debug-mochitest-e10s-2 2
>      2 - desktop-test-linux64/debug-reftest-no-accel-6 Ru6
>      2 - desktop-test-linux64/debug-web-platform-tests-e10s-5 5
>      2 - desktop-test-linux64/debug-mochitest-browser-chrome-1 bc1
>      2 - desktop-test-linux64/debug-mochitest-browser-chrome-7 bc7
>      2 - desktop-test-linux64/debug-reftest-no-accel-e10s-6 Ru6
>      2 - desktop-test-linux64/debug-mochitest-browser-chrome-e10s-7 bc7
>      2 - desktop-test-linux64/debug-reftest-e10s-6 R6
>      2 - desktop-test-linux64/debug-web-platform-tests-5 5
>      2 - desktop-test-linux64/debug-reftest-6 R6
>      1 - desktop-test-linux64/debug-mochitest-6 6
>      1 - desktop-test-linux64/debug-mochitest-e10s-6 6

It shows up in 422 tests. A few of the most prevalent:

>     75 -        layout/base/tests/test_reftests_with_caret.html
>     75 - [e10s] layout/base/tests/test_reftests_with_caret.html
>     39 -        editor/libeditor/tests/test_bug681229.html
>     39 - [e10s] editor/libeditor/tests/test_bug681229.html
>     31 -        editor/libeditor/tests/test_bug625452.html
>     27 - [e10s] editor/libeditor/tests/test_bug620906.html
>     23 -        file:///home/worker/workspace/build/tests/reftest/tests/gfx/tests/crashtests/306902-1.xml
>     23 -        editor/libeditor/tests/test_spellcheck_pref.html
>     21 -        file:///home/worker/workspace/build/tests/reftest/tests/editor/reftests/997805.html == file:///home/worker/workspace/build/tests/reftest/tests/editor/reftests/997805-ref.html
>     20 -        file:///home/worker/workspace/build/tests/reftest/tests/editor/libeditor/crashtests/761861.html

[1] https://hg.mozilla.org/mozilla-central/annotate/9ec789c0ee5b/editor/libeditor/EditorBase.cpp#l663

Comment 1

[Eric Rahm [:erahm]]

This has become slightly more verbose and continues to be a top warning.

Comment 2

[Jens Stutte [:jstutte]]

Bulk-downgrade of unassigned, >=3 years untouched DOM/Storage bug's priority.

If you have reason to believe this is wrong, please write a comment and ni :jstutte.

Comment 3

[Andrew McCreight [:mccr8]]

I don't see anything that looks like this warning any more. Bug 1620504 cleaned up a lot of editor warnings and changed the line the warning appeared on so maybe that is related.