1290315 - Please deploy tokenserver 1.2.23

Status: VERIFIED FIXED

(Cloud Services :: Operations: Deployment Requests - DEPRECATED, task)

Description

[Ryan Kelly [:rfkelly]]

This version includes support for returning the hashed FxA uid to the client, to be included in metrics pings, per Bug 1288445

Tagged at:

  https://github.com/mozilla-services/tokenserver/releases/tag/1.2.23

Comment 1

[Benson Wong [:mostlygeek]]

This has been deployed to stage. 

:rfkelly, does this need to be QA'd before rolling out to prod?

Comment 2

[Ryan Kelly [:rfkelly]]

Yes, a basic sanity-check is probably a good idea :-)

ni? Karl for a loadtest run, and ni? :markh to confirm whether the expected new field is being returned in the tokenserver response from stage in the correct fashion

Comment 3

[Karl Thiessen [:kthiessen, he/him]]

I will run load tests against this tomorrow or Thursday and report back results.

Comment 4

[Mark Hammond [:markh] [:mhammond]]

(In reply to Ryan Kelly [:rfkelly] from comment #2)
> ni? Karl for a loadtest run, and ni? :markh to confirm whether the expected
> new field is being returned in the tokenserver response from stage in the
> correct fashion

Thom is working on atomic writes (which also requires use of stage) and is also assigned the bug for sending this hash in the ping, so I'll punting the needinfo to him :)

Comment 5

[Thom Chiovoloni [:tcsc] (ex-moco)]

Yep, it's there on stage.

Comment 6

[Thom Chiovoloni [:tcsc] (ex-moco)]

Ack, sorry about this, I was looking at the fxa_uid field yesterday (I was still recovering from being sick -- sorry!)

Anyway, as far as I can tell, the hashed_fxa_uid field is *not* on stage... Unless I'm configured wrong, which is totally possible (The tokenserver uri is https://token.stage.mozaws.net/1.0/sync/1.5, and the server claims to be https://sync-1-us-east-1.stage.mozaws.net). Ping me on irc if you think this is the case.

Comment 7

[Benson Wong [:mostlygeek]]

Version (1.2.23) of tokenserver is on stage. 
https://token.stage.mozaws.net is also the correct endpoint.

Comment 8

[Mark Hammond [:markh] [:mhammond]]

I just tested against staging and when requesting a token from https://token.stage.mozaws.net/1.0/sync/1.5, the response included |hashed_fxa_uid:"baaa901a7890c6d5fc63656586fde509"|, so ISTM that this is working correctly.

Comment 9

[Karl Thiessen [:kthiessen, he/him]]

Load tests return unsurprising values, according to both bobm and myself.  This looks to be good to go to prod.

Comment 10

[Benson Wong [:mostlygeek]]

Deployed to production.

Comment 11

[Karl Thiessen [:kthiessen, he/him]]

Verified.