Closed Bug 1290332 Opened 3 years ago Closed 3 years ago

NSS automation should update MSVC after bug 1289638

Categories

(NSS :: Build, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: glandium, Assigned: ttaubert)

References

Details

Attachments

(1 file, 1 obsolete file)

Bug 1289638 is updating the tooltool msvc package to make it look more like local installs. Future updates of the compiler (think, when upgrading to update 3), will have the same new layout.

NSS automation should switch to the new package in order to more easily update in the future.
Depends on: 1289638
Comment on attachment 8775964 [details] [diff] [review]
Update MSVC

Review of attachment 8775964 [details] [diff] [review]:
-----------------------------------------------------------------

::: automation/taskcluster/windows/setup.sh
@@ +15,2 @@
>  
> +export INCLUDE="${VSPATH}/VC/include:${VSPATH}/VC/atlmfc/include:${VSPATH}/SDK/Include/10.0.10586.0/ucrt:${VSPATH}/SDK/Include/10.0.10586.0/shared:${VSPATH}/SDK/Include/10.0.10586.0/um:${VSPATH}/SDK/Include/10.0.10586.0/winrt:${VSPATH}/DIASDK/include"

The DIA SDK directory is lacking a space. But in fact, you don't need it. For the Gecko build, it's only used for breakpad stuff.
You probably also don't need winrt, and maybe not atlmfc.
Attachment #8775964 - Flags: review?(mh+mozilla)
You're right. Everything still works with all your suggested changes:

https://treeherder.mozilla.org/#/jobs?repo=nss-try&revision=930d7be482f79559c59b54ff234c719acef14602
Assignee: nobody → ttaubert
Attachment #8775964 - Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #8777210 - Flags: review?(mh+mozilla)
Attachment #8777210 - Flags: review?(mh+mozilla) → review+
https://hg.mozilla.org/projects/nss/rev/57baa3d554be
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 3.27
You need to log in before you can comment on or make changes to this bug.