1290332 - NSS automation should update MSVC after bug 1289638

Status: RESOLVED FIXED

(NSS :: Build, defect)

Description

[Mike Hommey [:glandium]]

Bug 1289638 is updating the tooltool msvc package to make it look more like local installs. Future updates of the compiler (think, when upgrading to update 3), will have the same new layout.

NSS automation should switch to the new package in order to more easily update in the future.

Comment 1

[Tim Taubert [:ttaubert] (inactive)]

Attachment: Update MSVC

That seems to work:

https://treeherder.mozilla.org/#/jobs?repo=nss-try&revision=d12b835efa8d4085f50fc1eb579b0382c6c85008

Comment 2

[Mike Hommey [:glandium]]

Comment on attachment 8775964 [details] [diff] [review]
Update MSVC

Review of attachment 8775964 [details] [diff] [review]:
-----------------------------------------------------------------

::: automation/taskcluster/windows/setup.sh
@@ +15,2 @@
>  
> +export INCLUDE="${VSPATH}/VC/include:${VSPATH}/VC/atlmfc/include:${VSPATH}/SDK/Include/10.0.10586.0/ucrt:${VSPATH}/SDK/Include/10.0.10586.0/shared:${VSPATH}/SDK/Include/10.0.10586.0/um:${VSPATH}/SDK/Include/10.0.10586.0/winrt:${VSPATH}/DIASDK/include"

The DIA SDK directory is lacking a space. But in fact, you don't need it. For the Gecko build, it's only used for breakpad stuff.
You probably also don't need winrt, and maybe not atlmfc.

Comment 3

[Tim Taubert [:ttaubert] (inactive)]

Attachment: 0001-Bug-1290332-Update-MSVC-for-NSS-automation.patch

You're right. Everything still works with all your suggested changes:

https://treeherder.mozilla.org/#/jobs?repo=nss-try&revision=930d7be482f79559c59b54ff234c719acef14602

Comment 4

[Tim Taubert [:ttaubert] (inactive)]

https://hg.mozilla.org/projects/nss/rev/57baa3d554be