Closed
Bug 1290336
Opened 8 years ago
Closed 8 years ago
Building ICU via moz.build files disabled ICU's U_ASSERT macro in debug builds
Categories
(Firefox Build System :: General, defect)
Firefox Build System
General
Tracking
(firefox51 fixed)
RESOLVED
FIXED
mozilla51
| Tracking | Status | |
|---|---|---|
| firefox51 | --- | fixed |
People
(Reporter: Waldo, Assigned: xidorn)
References
Details
Attachments
(1 file)
Bug 914236, an assertion in ICU, stopped reproducing in debug builds when the switch to moz.build files occurred. This is almost certainly because ICU's assertion macro is no longer enabled. Could we get that reenabled, please?
|
Assignee | |
Comment 1•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/67928/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/67928/
Attachment #8775864 -
Flags: review?(mh+mozilla)
|
||
Updated•8 years ago
|
Attachment #8775864 -
Flags: review?(mh+mozilla) → review+
|
|
||
Comment 2•8 years ago
|
||
Comment on attachment 8775864 [details] Bug 1290336 - Define U_DEBUG flag for ICU in debug build. https://reviewboard.mozilla.org/r/67928/#review65574
|
||
Comment 3•8 years ago
|
||
Sorry. :-(
|
|
||
Updated•8 years ago
|
Assignee: nobody → xidorn+moz
|
|
Assignee | |
Updated•8 years ago
|
Keywords: checkin-needed
Pushed by cbook@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/ea02aab4d4c5 Define U_DEBUG flag for ICU in debug build. r=glandium
Keywords: checkin-needed
|
||
Comment 5•8 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/ea02aab4d4c5
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox51:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla51
|
||
Updated•6 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•