Closed
Bug 1290402
Opened 8 years ago
Closed 8 years ago
Baldr: Bump MaxTableElems
Categories
(Core :: JavaScript Engine: JIT, defect)
Core
JavaScript Engine: JIT
Tracking
()
RESOLVED
FIXED
mozilla51
People
(Reporter: bbouvier, Assigned: bbouvier)
References
Details
Attachments
(1 file)
|
2.22 KB,
patch
|
luke
:
review+
|
Details | Diff | Splinter Review |
There has been reports that 128 K table elements is not enough. How about bumping this limit to 1 M table elements? Alon, will it be enough?
Attachment #8775904 -
Flags: review?(luke)
Attachment #8775904 -
Flags: feedback?(azakai)
|
||
Updated•8 years ago
|
Attachment #8775904 -
Flags: review?(luke) → review+
|
|
||
Comment 1•8 years ago
|
||
Thanks!
|
||
Comment 2•8 years ago
|
||
Comment on attachment 8775904 [details] [diff] [review] bump.patch I don't know if 1M is enough - just that a user reported seeing this error, where it worked on chrome but not firefox. I don't actually have the testcase. I guess it's not possible to not have a limit?
Attachment #8775904 -
Flags: feedback?(azakai)
|
|
||
Comment 3•8 years ago
|
||
Limits are useful to prevent tiny wasm files from trivially OOMing the browser.
Pushed by bbouvier@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/fd36d8af215c Bump MaxTableElems; r=luke
|
||
Comment 5•8 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/fd36d8af215c
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox51:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla51
You need to log in
before you can comment on or make changes to this bug.
Description
•