1290495 - Refresh prompt shows up on reinstall even after profile is deleted

Status: NEW

(Firefox :: Migration, defect, P3)

Description

[Verdi [:verdi] Best to slack me]

Attachment: refresh.png

STR:
1. Perform a clean install of Nightly.
2. Notice that you see a notification bar saying, "Looks like you've reinstalled Nightly..."

Expected: No infobar on a new install.

Comment 1

[Jared Wein [:jaws] (please needinfo? me)]

Can you reproduce this all the time with just those steps? I feel like there's got to be something else at play here too.

Comment 2

[Justin Dolske [:Dolske]]

Relevant code:

http://searchfox.org/mozilla-central/rev/3df383b8552c1f8059f5c21258388ddb5a2f33d0/browser/components/nsBrowserGlue.js#1115

Are you uninstalling Firefox as part of the "clean install"? The code just checks to see if there's a certain registry key set by uninstalling, and if so it clears it and shows the prompt. (It's independent of anything in in a profile.)

Maybe the check here should also include seeing if "lastUse" is set (or some other indication that this is the first run in a new profile), since it's silly to try and reset Firefox when there isn't actually something there.

In general this is a bit of a tricky problem, since when the system uninstaller runs it doesn't know anything about profiles, and that can lead to some edge cases that are probably not handled well here. (EG, if you have multiple profiles, we'll only offer to reset one of them.)

Comment 3

[Verdi [:verdi] Best to slack me]

(In reply to Justin Dolske [:Dolske] from comment #2)
> Are you uninstalling Firefox as part of the "clean install"? The code just
> checks to see if there's a certain registry key set by uninstalling, and if
> so it clears it and shows the prompt. (It's independent of anything in in a
> profile.)

Yes. My steps for a clean install:
1. Open the control panel, select Firefox(s) and choose "uninstall"
2. Try to uninstall the maintenance service (sometimes this isn't necessary and sometimes it is)
3. Delete the Mozilla folder in AppData/Roaming and in AppData/Local
4. Empty the recycle bin

Comment 4

[Justin Dolske [:Dolske]]

Yeah, so it's "expected" that the prompt is shown because you're reinstalling. Per comment 2 we should add an extra check to suppress this when we see you're in a fresh new profile.

I'd expect this is somewhat uncommon for users to hit in the wild, since you have to know how to delete your profile. But still worth fixing.

Comment 5

[:Gijs (out for now; he/him)]

The refresh related stuff has historically lived in Fx::General or Fx::Migration, so moving this across because it's not really related to our notification or alert implementations.