1290616 - NSS build system uses /usr/bin/link in msys2

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Mike Hommey [:glandium]]

Normally, I'd fix that in bug 1290040, but that depends on patches from bug 1290334, and I don't want to block 1290040 on 1290334.

Comment 1

[Mike Hommey [:glandium]]

Attachment: Bug 1290616 - Pass down LD to the NSS build system.

as opposed to only when cross compiling. This ensures the full path to
link.exe is used when building NSS, avoiding it to pick /usr/bin/link on
msys2.

Review commit: https://reviewboard.mozilla.org/r/68092/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/68092/

Comment 2

[Gregory Szorc [:gps]]

Comment on attachment 8776187 [details]
Bug 1290616 - Pass down LD to the NSS build system.

https://reviewboard.mozilla.org/r/68092/#review65210

Comment 3

[Mike Hommey [:glandium]]

Comment on attachment 8776187 [details]
Bug 1290616 - Pass down LD to the NSS build system.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/68092/diff/1-2/

Comment 4

[Mike Hommey [:glandium]]

Comment on attachment 8776187 [details]
Bug 1290616 - Pass down LD to the NSS build system.

Gah, forgot that mozreview doesn't reset flags. I do want a re-review.

Comment 5

[Gregory Szorc [:gps]]

Comment on attachment 8776187 [details]
Bug 1290616 - Pass down LD to the NSS build system.

https://reviewboard.mozilla.org/r/68092/#review66222

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8538a05d5ba3
Pass down LD to the NSS build system. r=gps

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/8538a05d5ba3