Closed Bug 1290616 Opened 4 years ago Closed 4 years ago

NSS build system uses /usr/bin/link in msys2

Categories

(Firefox Build System :: General, defect)

defect
Not set

Tracking

(firefox51 fixed)

RESOLVED FIXED
mozilla51
Tracking Status
firefox51 --- fixed

People

(Reporter: glandium, Assigned: glandium)

References

Details

Attachments

(1 file)

Normally, I'd fix that in bug 1290040, but that depends on patches from bug 1290334, and I don't want to block 1290040 on 1290334.
Blocks: 1100925
as opposed to only when cross compiling. This ensures the full path to
link.exe is used when building NSS, avoiding it to pick /usr/bin/link on
msys2.

Review commit: https://reviewboard.mozilla.org/r/68092/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/68092/
Attachment #8776187 - Flags: review?(gps)
Comment on attachment 8776187 [details]
Bug 1290616 - Pass down LD to the NSS build system.

https://reviewboard.mozilla.org/r/68092/#review65210
Attachment #8776187 - Flags: review?(gps) → review+
Comment on attachment 8776187 [details]
Bug 1290616 - Pass down LD to the NSS build system.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/68092/diff/1-2/
Attachment #8776187 - Attachment description: Bug 1290616 - Always set LINK when invoking NSS build system. → Bug 1290616 - Pass down LD to the NSS build system.
Comment on attachment 8776187 [details]
Bug 1290616 - Pass down LD to the NSS build system.

Gah, forgot that mozreview doesn't reset flags. I do want a re-review.
Attachment #8776187 - Flags: review+ → review?(gps)
Comment on attachment 8776187 [details]
Bug 1290616 - Pass down LD to the NSS build system.

https://reviewboard.mozilla.org/r/68092/#review66222
Attachment #8776187 - Flags: review?(gps) → review+
Pushed by mh@glandium.org:
https://hg.mozilla.org/integration/autoland/rev/8538a05d5ba3
Pass down LD to the NSS build system. r=gps
https://hg.mozilla.org/mozilla-central/rev/8538a05d5ba3
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla51
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.