1290625 - Assertion failed: (r == 0 && "Deadlock") on OSX when getting microphone with getUserMedia

Status: RESOLVED FIXED

(Core :: Audio/Video: cubeb, defect)

Description

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

The landing of bug 1290425 apparently causes a deadlock (or at least a deadlock assert) on OSX:

  Assertion failed: (r == 0 && "Deadlock"), function enter, file /Users/Jan/moz/mozilla-inbound/media/libcubeb/src/cubeb_utils_unix.h, line 58.

This happens from this call: https://dxr.mozilla.org/mozilla-central/rev/2ea3d51ba1bb9f5c3b6921c43ea63f70b4fdf5d2/dom/media/GraphDriver.cpp#1057

Comment 1

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

Attachment: Bug 1290625 - Make libcubeb mutex recurse again, to avoid deadlock when getting microphone.

Review commit: https://reviewboard.mozilla.org/r/68114/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/68114/

Comment 2

[Alex Chronopoulos [:achronop]]

Comment on attachment 8776205 [details]
Bug 1290625 - Make libcubeb mutex recurse again, to avoid deadlock when getting microphone.

https://reviewboard.mozilla.org/r/68114/#review65226

Looks good thanks!

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f60ec9e34d4d
Make libcubeb mutex recurse again, to avoid deadlock when getting microphone. r=achronop

Comment 4

[Carsten Book [:Tomcat]]

sorry had to back this out from autoland since this caused a merge conflict with m-c in 
warning: conflicts while merging media/libcubeb/src/cubeb_utils_unix.h! (edit, then use 'hg resolve --mark')

Comment 5

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2ba03ba34ece
Backed out changeset f60ec9e34d4d for causing merge conflict with m-c

Comment 6

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

I'm confused, can we not autoland follow-on patches built on mozilla-inbound locally before code we're fixing has merged to m-c?

This patch was supposed to go on top of Bug 1290425 comment 5, on inbound at that time (which I see it only merged to m-c this morning at 10am). This patch was supposed to be a one-liner, instead I see it pushed the whole file (comment 3). Does autoland have its own staging server now separate from inbound?

At this point I can just rebease and re-push?

Comment 7

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

Comment on attachment 8776205 [details]
Bug 1290625 - Make libcubeb mutex recurse again, to avoid deadlock when getting microphone.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/68114/diff/1-2/

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c761bfb5fd83
Make libcubeb mutex recurse again, to avoid deadlock when getting microphone. r=achronop

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/c761bfb5fd83