1290636 - Expose iterator stuff on NodeList and DOMTokenList

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Boris Zbarsky [:bzbarsky]]

The DOM spec has these.  Chrome is shipping at least on NodeList (as in, it's in Chrome release), which suggests it's web-compatible.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Attachment: Fix some bugs in the way single-type (value) iterators are hooked up in the Web IDL bindings

There were two issues:

1) The keys/entries/values/forEach properties were being added no matater what
the value of the 'unforgeable' boolean was.  So we ended up spitting out
unforgeable versions of those, and this confused some Xray cases.

2) The number of args listed for forEach was wrong, which hit assertions in the
JS engine because the same self-hosted function was being instantiated with
different numbers of args from different places.

Comment 2

[Boris Zbarsky [:bzbarsky]]

Attachment: Fix some bugs in the way single-type (value) iterators are hooked up in the Web IDL bindings

There were two issues:

1) The keys/entries/values/forEach properties were being added no matater what
the value of the 'unforgeable' boolean was.  So we ended up spitting out
unforgeable versions of those, and this confused some Xray cases.

2) The number of args listed for forEach was wrong, which hit assertions in the
JS engine because the same self-hosted function was being instantiated with
different numbers of args from different places.

Comment 3

[Boris Zbarsky [:bzbarsky]]

Attachment: Expose iterator stuff on NodeList and DOMStringList

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/6b62785dbfe3
Fix some bugs in the way single-type (value) iterators are hooked up in the Web IDL bindings.  r=qdot
https://hg.mozilla.org/integration/mozilla-inbound/rev/49efb446f5b0
Expose iterator stuff on NodeList and DOMStringList.  r=qdot

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/6b62785dbfe3
https://hg.mozilla.org/mozilla-central/rev/49efb446f5b0

Comment 7

[Eric Shepherd [:sheppy]]

Note for documentation team: see specifications: https://dom.spec.whatwg.org/#interface-nodelist and https://dom.spec.whatwg.org/#interface-domtokenlist; also, this is already shipping in Chrome stable. No information on Safari or Edge implementation plans at this time.

Comment 8

[Jean-Yves Perrier [:teoli]]

Updated:
https://developer.mozilla.org/en-US/Firefox/Releases/50
https://developer.mozilla.org/en-US/docs/Web/API/NodeList
https://developer.mozilla.org/en-US/docs/Web/API/DOMTokenList

Created:
https://developer.mozilla.org/en-US/docs/Web/API/NodeList/forEach
https://developer.mozilla.org/en-US/docs/Web/API/NodeList/entries
https://developer.mozilla.org/en-US/docs/Web/API/NodeList/keys
https://developer.mozilla.org/en-US/docs/Web/API/NodeList/values
https://developer.mozilla.org/en-US/docs/Web/API/DOMTokenList/forEach
https://developer.mozilla.org/en-US/docs/Web/API/DOMTokenList/entries
https://developer.mozilla.org/en-US/docs/Web/API/DOMTokenList/keys
https://developer.mozilla.org/en-US/docs/Web/API/DOMTokenList/values