1290761 - Allow running jprof with sandbox enabled

Status: RESOLVED FIXED

(Core :: Security: Process Sandboxing, defect)

Description

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

jprof is an in-tree profiling tool that runs on Linux.

This fixes the error:

Sandbox: seccomp sandbox violation: pid 29698, syscall 38, args 0 140731305513136 0 830 22509600 1.  Killing process.
Sandbox: crash reporter is disabled (or failed); trying stack trace:
Sandbox: frame #01: __GI_setitimer (/build/glibc-GKVZIf/glibc-2.23/time/../sysdeps/unix/syscall-template.S:84)
Sandbox: frame #02: startSignalCounter(unsigned long) (.../mozilla-central/mozilla/tools/jprof/stub/libmalloc.cpp:464)

which occurs during shutdown when running with jprof enabled via the
JPROF_FLAGS environment variable containing JP_DEFER without actually
sending the signal to start jprof.  It presumably occurs sooner if jprof
is actually used either via JP_START or by senging a SIGPROF/SIGALRM.

With the patch, these steps run to completion.

MozReview-Commit-ID: Fx4tzEyqIj2

Comment 1

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Attachment: Allow running jprof with sandbox enabled

Comment 2

[Julian Hector [:tedd] [:jhector]]

Comment on attachment 8776417 [details] [diff] [review]
Allow running jprof with sandbox enabled

Review of attachment 8776417 [details] [diff] [review]:
-----------------------------------------------------------------

The system call in question: sys_setitimer() seem to be harmless and it is only whitelisted for JPROF.

lgtm.

Comment 3

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/eadaa06966fefa5ea284da51a8d58ef2423edf47
Bug 1290761 - Allow running jprof with sandbox enabled.  r=jhector

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/eadaa06966fe