1290770 - Crash in mozilla::WebGLTexture::CopyTexImage2D, with no log of failed call args.

Status: RESOLVED FIXED

(Core :: Graphics: CanvasWebGL, defect, P3)

Description

[Nicholas Nethercote [inactive]]

This bug was filed from the Socorro interface and is 
report bp-feeabbf6-9003-4cc7-8efb-e469a2160527.
=============================================================

I only see 5 occurrences of this crash, 4 on Linux, 1 on Windows, but it's a nice understandable MOZ_RELEASE_ASSERT failure so seems worth filing.

jgilbert, any ideas?

Comment 1

[Jerry Shih[:jerry] (UTC+8) (inactive)]

Attachment: show gl error code in WebGLTexture function. v1

We don't know the error code with this assert[1]. Add more info for debugging.
This crash also can be found at ff50[2].

[1]
https://hg.mozilla.org/mozilla-unified/annotate/2ea3d51ba1bb/dom/canvas/WebGLTextureUpload.cpp#l2107
[2]
https://crash-stats.mozilla.com/report/index/795be08c-542e-46b9-a0e4-9bbc32160730

Comment 2

[Kelsey Gilbert [:jgilbert]]

This is probably bug 1290634.

Comment 3

[Jerry Shih[:jerry] (UTC+8) (inactive)]

Maybe it's solved by bug 1290634. But I think it's worth to have attachment 8776490 [details] [diff] [review]. Then we can check the gl parameters if there has another error code.

Comment 4

[Sylvestre Ledru [:Sylvestre]]

Closing because no crash reported since 12 weeks.

Comment 5

[Sylvestre Ledru [:Sylvestre]]

Closing because no crash reported since 12 weeks.

Comment 7

[Kelsey Gilbert [:jgilbert]]

Attachment: Bug 1290770 - Log bad tex upload calls and errors.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4044c8713862
Log bad tex upload calls and errors. r=lsalzman

Comment 9

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/4044c8713862