Closed Bug 1290949 Opened 8 years ago Closed 6 years ago

pc.removeTrack should not remove sender from pc.getSenders()

Categories

(Core :: WebRTC: Signaling, defect, P3)

defect

Tracking

()

RESOLVED FIXED
mozilla60
Tracking Status
firefox60 --- fixed

People

(Reporter: jib, Assigned: bwc)

References

Details

(Keywords: dev-doc-complete)

Attachments

(1 file)

The arrival of transceivers in the spec affects the behavior of our already implemented pc.removeTrack, which in the spec was subsequently changed [2] to no longer remove the sender from getSenders().

May not make sense to fix until we add transceivers (Bug 1290948).

[1] https://github.com/w3c/webrtc-pc/commit/67f7c4108c40434fc4e9bfbf77b7d909a39b4db3#diff-25266486aad3fa9244c53420694e037eL2519
backlog: --- → webrtc/webaudio+
Rank: 28
Component: WebRTC → WebRTC: Signaling
Priority: -- → P2
Mass change P2->P3 to align with new Mozilla triage process.
Priority: P2 → P3
This is probably fixed in bug 1290948, but we should probably have a removeTrack test in test_peerConnection_transceivers.html.
Assignee: nobody → docfaraday
Comment on attachment 8951730 [details]
Bug 1290949: Test that removeTrack does not remove the associated sender.

https://reviewboard.mozilla.org/r/221008/#review227498
Attachment #8951730 - Flags: review?(jib) → review+
Pushed by bcampen@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/3ae40dfba516
Test that removeTrack does not remove the associated sender. r=jib
https://hg.mozilla.org/mozilla-central/rev/3ae40dfba516
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
You need to log in before you can comment on or make changes to this bug.