pc.removeTrack should not remove sender from pc.getSenders()

RESOLVED FIXED in Firefox 60

Status

()

P3
normal
Rank:
28
RESOLVED FIXED
3 years ago
9 months ago

People

(Reporter: jib, Assigned: bwc)

Tracking

({dev-doc-complete})

Trunk
mozilla60
dev-doc-complete
Points:
---

Firefox Tracking Flags

(firefox60 fixed)

Details

Attachments

(1 attachment)

The arrival of transceivers in the spec affects the behavior of our already implemented pc.removeTrack, which in the spec was subsequently changed [2] to no longer remove the sender from getSenders().

May not make sense to fix until we add transceivers (Bug 1290948).

[1] https://github.com/w3c/webrtc-pc/commit/67f7c4108c40434fc4e9bfbf77b7d909a39b4db3#diff-25266486aad3fa9244c53420694e037eL2519
Keywords: dev-doc-needed
(Assignee)

Updated

3 years ago
backlog: --- → webrtc/webaudio+
Rank: 28
Component: WebRTC → WebRTC: Signaling
Priority: -- → P2
Mass change P2->P3 to align with new Mozilla triage process.
Priority: P2 → P3
(Assignee)

Comment 2

a year ago
This is probably fixed in bug 1290948, but we should probably have a removeTrack test in test_peerConnection_transceivers.html.
Assignee: nobody → docfaraday
Comment hidden (mozreview-request)
(Reporter)

Comment 4

a year ago
mozreview-review
Comment on attachment 8951730 [details]
Bug 1290949: Test that removeTrack does not remove the associated sender.

https://reviewboard.mozilla.org/r/221008/#review227498
Attachment #8951730 - Flags: review?(jib) → review+

Comment 5

a year ago
Pushed by bcampen@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/3ae40dfba516
Test that removeTrack does not remove the associated sender. r=jib

Comment 6

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/3ae40dfba516
Status: NEW → RESOLVED
Last Resolved: a year ago
status-firefox60: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
Updated https://developer.mozilla.org/en-US/docs/Web/API/RTCPeerConnection/removeTrack and Firefox 60 for developers to note this change.
Keywords: dev-doc-needed → dev-doc-complete
status-firefox51: affected → ---
You need to log in before you can comment on or make changes to this bug.