1291009 - Closed-caption button fuzzy in hidpi mode

Status: RESOLVED FIXED

(Toolkit :: Video/Audio Controls, defect)

Description

[Justin Dolske [:Dolske]]

Attachment: Screenshot

Bug 887934 added a closed-caption button to the default video controls, but it's fuzzy in hidpi mode

The patch has hidpi images, but I don't see any CSS to use them.

Demo page:
https://www.iandevlin.com/html5test/webvtt/html5-video-webvtt-sample.html

Comment 1

[Jared Wein [:jaws] (please needinfo? me)]

Ray, can you take this bug? We should get this fixed in Firefox 50 since it should be a simple fix.

[Tracking Requested - why for this release]: Visible UI blurriness in new feature shipping in v50.

Comment 2

[Ray Lin[:ralin]]

Attachment: Bug 1291009 - Fix closed caption button icon in hidpi mode.

Review commit: https://reviewboard.mozilla.org/r/68480/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/68480/

Comment 3

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8776813 [details]
Bug 1291009 - Fix closed caption button icon in hidpi mode.

https://reviewboard.mozilla.org/r/68480/#review65564

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/fx-team/rev/71c8d652e638
Fix closed caption button icon in hidpi mode. r=jaws

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/71c8d652e638

Comment 6

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8776813 [details]
Bug 1291009 - Fix closed caption button icon in hidpi mode.

Approval Request Comment
[Feature/regressing bug #]: bug 887934 was fixed in v50 but missed this icon in hidpi mode
[User impact if declined]: blurry closed caption icon
[Describe test coverage new/current, TreeHerder]: simple css typo change
[Risks and why]: none
[String/UUID change made/needed]: none

Comment 7

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Comment on attachment 8776813 [details]
Bug 1291009 - Fix closed caption button icon in hidpi mode.

CSS only, low risk, Aurora50+

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/e40ae26e776c