Closed Bug 1291009 Opened 3 years ago Closed 3 years ago

Closed-caption button fuzzy in hidpi mode

Categories

(Toolkit :: Video/Audio Controls, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla51
Tracking Status
firefox50 + fixed
firefox51 --- fixed

People

(Reporter: Dolske, Assigned: ralin)

References

Details

Attachments

(2 files)

Attached image Screenshot
Bug 887934 added a closed-caption button to the default video controls, but it's fuzzy in hidpi mode

The patch has hidpi images, but I don't see any CSS to use them.

Demo page:
https://www.iandevlin.com/html5test/webvtt/html5-video-webvtt-sample.html
Ray, can you take this bug? We should get this fixed in Firefox 50 since it should be a simple fix.

[Tracking Requested - why for this release]: Visible UI blurriness in new feature shipping in v50.
Flags: needinfo?(ralin)
Assignee: nobody → ralin
Status: NEW → ASSIGNED
Flags: needinfo?(ralin)
Attachment #8776813 - Flags: review?(jaws) → review+
Keywords: checkin-needed
Pushed by cbook@mozilla.com:
https://hg.mozilla.org/integration/fx-team/rev/71c8d652e638
Fix closed caption button icon in hidpi mode. r=jaws
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/71c8d652e638
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla51
Comment on attachment 8776813 [details]
Bug 1291009 - Fix closed caption button icon in hidpi mode.

Approval Request Comment
[Feature/regressing bug #]: bug 887934 was fixed in v50 but missed this icon in hidpi mode
[User impact if declined]: blurry closed caption icon
[Describe test coverage new/current, TreeHerder]: simple css typo change
[Risks and why]: none
[String/UUID change made/needed]: none
Attachment #8776813 - Flags: approval-mozilla-aurora?
Comment on attachment 8776813 [details]
Bug 1291009 - Fix closed caption button icon in hidpi mode.

CSS only, low risk, Aurora50+
Attachment #8776813 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
You need to log in before you can comment on or make changes to this bug.