Closed
Bug 1291231
Opened 9 years ago
Closed 9 years ago
Fix the test_css-properties-db.js error when enable mask
Categories
(Core :: Layout, defect)
Core
Layout
Tracking
()
RESOLVED
DUPLICATE
of bug 1294660
People
(Reporter: ethlin, Assigned: ethlin)
References
Details
Attachments
(1 file)
48.72 KB,
patch
|
heycam
:
review+
|
Details | Diff | Splinter Review |
The current try failures:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=0a9c30d01070&selectedJob=24912732
devtools/shared/tests/unit/test_css-properties-db.js | run_test - [run_test : 45] The client side CSS properties database names match those found on the platform. If this assertion fails, then the client side CSS properties list in devtools is out of date with the CSS properties on the platform. To fix this assertion open devtools/shared/css-properties-db.js and follow the instructions above the CSS_PROPERTIES on how to re-generate the list.
We should re-generate CSS_PROPERTIES list in devtools/shared/css-properties-db.js.
Assignee | ||
Comment 1•9 years ago
|
||
Update the list. I tested the patch locally.
I just pushed to the try server:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=f2b6a18bc1c7
Attachment #8776893 -
Flags: review?(cam)
Comment 2•9 years ago
|
||
Comment on attachment 8776893 [details] [diff] [review]
update the list.
Review of attachment 8776893 [details] [diff] [review]:
-----------------------------------------------------------------
Looks good, though please make sure to land it at the same time as bug 1251161. (This patch might have been better on that bug.)
Attachment #8776893 -
Flags: review?(cam) → review+
Assignee | ||
Comment 3•9 years ago
|
||
(In reply to Cameron McCormack (:heycam) from comment #2)
> Comment on attachment 8776893 [details] [diff] [review]
> update the list.
>
> Review of attachment 8776893 [details] [diff] [review]:
> -----------------------------------------------------------------
>
> Looks good, though please make sure to land it at the same time as bug
> 1251161. (This patch might have been better on that bug.)
Okay, thanks for the reminder.
Comment 4•9 years ago
|
||
I'll handle this patch in bug 1294660 and ensure all relevant patches could merge at one time.
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → DUPLICATE
You need to log in
before you can comment on or make changes to this bug.
Description
•