1291306 - No longer able to set CSS text-transform on <input>

Status: VERIFIED FIXED

(DevTools :: Inspector, defect, P1)

Description

[Kohei Yoshino [:kohei]]

Attachment: testcase

Just found a Nightly regression while creating a webpage with my friend, where the text-transform CSS property doesn't work on the <input> element. According to mozregression Bug 1235062 is the culprit, and looks like text-indent, letter-spacing and word-spacing are also affected.

Comment 1

[Pascal Chevrel:pascalc (PTO until April 26)]

Janx, Patrick is currently on PTO and it seems that Bug 1235062 caused this regression, is that something you could have a look at or point us to the right person to ask? Thanks

Comment 2

[Jan Keromnes [:janx]]

Patrick or Sebastin would be the right people to ask about this.

Sebastin, could you please have a quick look at this bug?

Comment 3

[Julian Descottes [:jdescottes]]

Serious regression -> P1. We will need to uplift the fix to 50.

Inspector bug triage, filter on CLIMBING SHOES.

Comment 4

[Julian Descottes [:jdescottes]]

Attachment: Bug 1291306 - update highlighter CSS selector to avoid leaking styles to content;

Even though the pseudo :-moz-native-anonymous is only available for chrome content, elements
such as INPUT tags were impacted by the reset styles defined with the selector ":-moz-native-anonymous"

The selector has to be specialized in order to make sure it only impacts devtools elements.

Review commit: https://reviewboard.mozilla.org/r/69818/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/69818/

Comment 5

[Tim Nguyen :ntim]

Comment on attachment 8778572 [details]
Bug 1291306 - update highlighter CSS selector to avoid leaking styles to content;

https://reviewboard.mozilla.org/r/69818/#review66926

Comment 6

[radgum]

 Please look: https://jsfiddle.net/gn2wcre7/1/

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/fx-team/rev/204b39c31233
update highlighter CSS selector to avoid leaking styles to content;r=ntim

Comment 8

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/204b39c31233

Comment 9

[Julian Descottes [:jdescottes]]

Comment on attachment 8778572 [details]
Bug 1291306 - update highlighter CSS selector to avoid leaking styles to content;

Approval Request Comment
[Feature/regressing bug #]: 1235062 
[User impact if declined]: opening devtools removes styles applied to <input> elements in the page (such as text-transform)
[Describe test coverage new/current, TreeHerder]: no tests currently covering this issue
[Risks and why]: low risk, only a CSS selector update
[String/UUID change made/needed]: n/a

Comment 10

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Hello Kohei, could you please confirm this issue is fixed as expected on a latest Nightly build? Thanks!

Comment 11

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Comment on attachment 8778572 [details]
Bug 1291306 - update highlighter CSS selector to avoid leaking styles to content;

Recent regression, CSS only, Aurora50+

Comment 12

[Kohei Yoshino [:kohei]]

LGTM on the latest Nightly :)

Comment 13

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/deba9752fc42