Closed Bug 1291306 Opened 3 years ago Closed 3 years ago

No longer able to set CSS text-transform on <input>

Categories

(DevTools :: Inspector, defect, P1)

50 Branch
defect

Tracking

(firefox48 unaffected, firefox49 unaffected, firefox50 fixed, firefox51 verified)

VERIFIED FIXED
Firefox 51
Tracking Status
firefox48 --- unaffected
firefox49 --- unaffected
firefox50 --- fixed
firefox51 --- verified

People

(Reporter: kohei, Assigned: jdescottes, Mentored)

References

Details

(Keywords: nightly-community, regression, testcase)

Attachments

(2 files)

Attached file testcase
Just found a Nightly regression while creating a webpage with my friend, where the text-transform CSS property doesn't work on the <input> element. According to mozregression Bug 1235062 is the culprit, and looks like text-indent, letter-spacing and word-spacing are also affected.
Severity: minor → normal
Priority: P2 → --
Janx, Patrick is currently on PTO and it seems that Bug 1235062 caused this regression, is that something you could have a look at or point us to the right person to ask? Thanks
Flags: needinfo?(janx)
Patrick or Sebastin would be the right people to ask about this.

Sebastin, could you please have a quick look at this bug?
Flags: needinfo?(janx) → needinfo?(sebastinssanty)
Serious regression -> P1. We will need to uplift the fix to 50.

Inspector bug triage, filter on CLIMBING SHOES.
Priority: -- → P1
Even though the pseudo :-moz-native-anonymous is only available for chrome content, elements
such as INPUT tags were impacted by the reset styles defined with the selector ":-moz-native-anonymous"

The selector has to be specialized in order to make sure it only impacts devtools elements.

Review commit: https://reviewboard.mozilla.org/r/69818/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/69818/
Attachment #8778572 - Flags: review?(ntim.bugs)
Assignee: nobody → jdescottes
Status: NEW → ASSIGNED
Comment on attachment 8778572 [details]
Bug 1291306 - update highlighter CSS selector to avoid leaking styles to content;

https://reviewboard.mozilla.org/r/69818/#review66926
Attachment #8778572 - Flags: review?(ntim.bugs) → review+
Pushed by jdescottes@mozilla.com:
https://hg.mozilla.org/integration/fx-team/rev/204b39c31233
update highlighter CSS selector to avoid leaking styles to content;r=ntim
https://hg.mozilla.org/mozilla-central/rev/204b39c31233
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 51
Comment on attachment 8778572 [details]
Bug 1291306 - update highlighter CSS selector to avoid leaking styles to content;

Approval Request Comment
[Feature/regressing bug #]: 1235062 
[User impact if declined]: opening devtools removes styles applied to <input> elements in the page (such as text-transform)
[Describe test coverage new/current, TreeHerder]: no tests currently covering this issue
[Risks and why]: low risk, only a CSS selector update
[String/UUID change made/needed]: n/a
Flags: needinfo?(sebastinssanty)
Attachment #8778572 - Flags: approval-mozilla-aurora?
Hello Kohei, could you please confirm this issue is fixed as expected on a latest Nightly build? Thanks!
Flags: needinfo?(kohei.yoshino)
Comment on attachment 8778572 [details]
Bug 1291306 - update highlighter CSS selector to avoid leaking styles to content;

Recent regression, CSS only, Aurora50+
Attachment #8778572 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
LGTM on the latest Nightly :)
Status: RESOLVED → VERIFIED
Flags: needinfo?(kohei.yoshino)
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.