1291322 - Manually throttle CssRuleView tests

Status: RESOLVED FIXED

(DevTools :: Inspector, defect, P1)

Description

[Greg Tatum [:gregtatum]]

Throttle is creating non-deterministic behavior for the mochitests on the CssRuleView components, causing issues with modifying the internals of the inspector. Replace the throttle function in tests with a manually triggered throttle that can be controlled in a more deterministic manner.

https://dxr.mozilla.org/mozilla-central/rev/ffac2798999c5b84f1b4605a1280994bb665a406/devtools/client/inspector/rules/views/text-property-editor.js#79

Comment 1

[Greg Tatum [:gregtatum]]

Attachment: Bug 1291322 - Manually throttle CssRuleView tests;

This patch provides a mechanism for overriding the throttle function in
inspector tests with a manually controllable throttle. I did modify a
few tests to not check for a second "ruleview-changed" as it required
using a setTimeout to defer the code to the next frame to get it to work
as it currently exists. I figured it was safer to just not flush the
throttle, and reduce how many "ruleview-changed" events that the test
expected.

Review commit: https://reviewboard.mozilla.org/r/68666/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/68666/

Comment 2

[Tom Tromey :tromey]

Comment on attachment 8777066 [details]
Bug 1291322 - Manually throttle CssRuleView tests;

https://reviewboard.mozilla.org/r/68666/#review65736

This looks good to me.

As I mentioned on irc I'm vaguely concerned about new intermittents; but I suppose we'll know soon enough.

Thank you for doing this.

Comment 3

[Greg Tatum [:gregtatum]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=da7976326a77

Comment 4

[Greg Tatum [:gregtatum]]

Comment on attachment 8777066 [details]
Bug 1291322 - Manually throttle CssRuleView tests;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/68666/diff/1-2/

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5a12087afd6b
Manually throttle CssRuleView tests; r=tromey

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/5a12087afd6b