1291339 - A location change without load does not trigger a favicon load

Status: RESOLVED INCOMPLETE

(Firefox for Android Graveyard :: Favicon Handling, defect, P5)

Description

[Sebastian Kaspari (:sebastian; :pocmo)]

It looks like the mobile YouTube site changes the location if you switch tabs but no page load is triggered.

The new location is added to the history but as we never received a page load we never tried to load a favicon and therefore do not store an icon or the mapping from page URL to icon URL.

Comment 1

[Nevin Chen(Not active on Bugzilla)]

Hi Sebastian.
May I know what content you were playing?
Maybe it was playing a playlist? 
I only saw AUDIO_PLAYING_CHANGE event but no LOCATION_CHANGE event.
And a new history is added with the next playing song.

I think in that case we don't need to load a new favicon?

Comment 2

[Sebastian Kaspari (:sebastian; :pocmo)]

> And a new history is added with the next playing song.

Yeah, and when you go to the history panel you'll see that only the first page load has an icon - all other visited pages do not.

> I think in that case we don't need to load a new favicon?

We do not load a favicon (It's in the cache) - but we need to go through the code to map the current page URL to that favicon.

Comment 3

[Nevin Chen(Not active on Bugzilla)]

Thanks Sebastian.
Although the fix may not be simple but the requirement is clear, so I'll mark it as a good first bug.

Comment 4

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

[triage] Bulk edit from title: this is a non-critical issue. Please remove priority if you wish this to be re-triaged.

Comment 5

[Firefox Bug Husbandry Bot]

Re-triaging per https://bugzilla.mozilla.org/show_bug.cgi?id=1473195

Needinfo :susheel if you think this bug should be re-triaged.

Comment 6

[BMO Automation]

We have completed our launch of our new Firefox on Android. The development of the new versions use GitHub for issue tracking. If the bug report still reproduces in a current version of [Firefox on Android nightly](https://play.google.com/store/apps/details?id=org.mozilla.fenix) an issue can be reported at the [Fenix GitHub project](https://github.com/mozilla-mobile/fenix/). If you want to discuss your report please use [Mozilla's chat](https://wiki.mozilla.org/Matrix#Connect_to_Matrix) server https://chat.mozilla.org and join the [#fenix](https://chat.mozilla.org/#/room/#fenix:mozilla.org) channel.