1291390 - Stylo: Wrong cascade level used for preferences stylesheet

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect)

Description

[Bobby Holley (:bholley)]

Right now we load the preferences stylesheet as an author stylesheet, rather than a user stylesheet. This causes it to take precedence over page-provided style rules, which isn't what happens in the gecko path and leads to incorrect behavior.

Bug 1291376 covers larger architectural issues that I'm not worrying about in this bug.

Comment 1

[Bobby Holley (:bholley)]

Attachment: Part 1 - Hoist the ParsingMode getter to the superclass and give it a special binary name for WebIDL. v1

In the next patch we want to introduce an accessor called ParsingMode, which conflicts with this one.

Comment 2

[Bobby Holley (:bholley)]

Attachment: Part 2 - Use the parsing mode from the stylesheet when building preferences stylesheet. v1

In practice this will be the 'agent' level rather than the 'author' level, given
the SetParsingMode call immediately after creating the stylesheet. This change
aligns behavior with CSSStyleSheet::ReparseSheet.

Comment 3

[Bobby Holley (:bholley)]

Attachment: Part 3 - Make parsing mode an immutable property of the StyleSheet. v1

Comment 4

[Cameron McCormack (:heycam)]

Comment on attachment 8777077 [details] [diff] [review]
Part 2 - Use the parsing mode from the stylesheet when building preferences stylesheet. v1

Review of attachment 8777077 [details] [diff] [review]:
-----------------------------------------------------------------

::: layout/style/nsLayoutStylesheetCache.cpp
@@ +950,5 @@
>  
>    if (sheet->IsGecko()) {
>      sheet->AsGecko()->ReparseSheet(sheetText);
>    } else {
> +    sheet->AsServo()->ParseSheet(sheetText, uri, uri, nullptr, 0, sheet->AsServo()->ParsingMode());

Nit: please wrap at 80 columns.

Comment 5

[Bobby Holley (:bholley)]

(In reply to Cameron McCormack (:heycam) from comment #4)
> Nit: please wrap at 80 columns.

This line is removed in the third patch anyway.

Comment 6

[Bobby Holley (:bholley)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=5da7a6c644a5&selectedJob=24971319

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/0ee3385b2da3
Hoist the ParsingMode getter to the superclass and give it a special binary name for WebIDL. r=bholley,r=heycam
https://hg.mozilla.org/integration/mozilla-inbound/rev/edd278067c96
Use the parsing mode from the stylesheet when building preferences stylesheet. r=heycam
https://hg.mozilla.org/integration/mozilla-inbound/rev/d6806f6068fd
Make parsing mode an immutable property of the StyleSheet. r=heycam

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/0ee3385b2da3
https://hg.mozilla.org/mozilla-central/rev/edd278067c96
https://hg.mozilla.org/mozilla-central/rev/d6806f6068fd