Closed Bug 1291618 Opened 5 years ago Closed 5 years ago

Fix dropmarker position of command-button-frames in RTL locales

Categories

(DevTools :: General, defect, P1)

defect

Tracking

(firefox49 affected, firefox50 affected, firefox51 verified)

VERIFIED FIXED
Firefox 51
Iteration:
51.1 - Aug 15
Tracking Status
firefox49 --- affected
firefox50 --- affected
firefox51 --- verified

People

(Reporter: magicp.jp, Assigned: rickychien, Mentored)

References

Details

(Whiteboard: [reserve-html] [good first bug][good taipei bug][lang=css])

Attachments

(2 files)

User Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:51.0) Gecko/20100101 Firefox/51.0
Build ID: 20160802030437

Steps to reproduce:

1. Start Nightly in RTL locales (e.g. Arabic)
2. Open DevTools
3. Check dropmarker position of command-button-frames


Actual results:

dropmarker position is right side.

Regression range:
https://hg.mozilla.org/integration/fx-team/pushloghtml?fromchange=3a87296fe4145138c2ce15512bb31f76fe869cb4&tochange=42fab251fe111d5f891c9bde0ee1fb6f7f946a50


Expected results:

dropmarker should be left side in RTL locales
Blocks: 1266419
Has Regression Range: --- → yes
Has STR: --- → yes
Component: Untriaged → Developer Tools
OS: Unspecified → All
Hardware: Unspecified → All
Flags: qe-verify+
QA Contact: alexandra.lucinet
Whiteboard: [devtools-html] [triage]
Mentor: ntim.bugs
Whiteboard: [devtools-html] [triage] → [devtools-html] [triage][good first bug][good taipei bug][lang=css]
Assignee: nobody → rchien
Status: NEW → ASSIGNED
Comment on attachment 8777713 [details]
Bug 1291618 - Fix dropmarker position of command-button-frames in RTL locales

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/69224/diff/1-2/
Comment on attachment 8777713 [details]
Bug 1291618 - Fix dropmarker position of command-button-frames in RTL locales

https://reviewboard.mozilla.org/r/69224/#review66364

Tested and works fine. Thanks!
Attachment #8777713 - Flags: review?(ntim.bugs) → review+
Keywords: checkin-needed
Priority: -- → P3
Whiteboard: [devtools-html] [triage][good first bug][good taipei bug][lang=css] → [reserve-html] [good first bug][good taipei bug][lang=css]
Pushed by cbook@mozilla.com:
https://hg.mozilla.org/integration/fx-team/rev/0636c302f407
Fix dropmarker position of command-button-frames in RTL locales. r=ntim
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/0636c302f407
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 51
Iteration: --- → 51.1 - Aug 15
Priority: P3 → P1
QA Contact: adalucin → cristian.comorasu
I reproduced this bug using Fx 51.0a1(ar), build ID:  20160802030437, on Windows 10 x64.

I can confirm the bug is fixed, I verified using Fx 51.0a1(ar) build ID: 20160817030202, on Windows 10 x64, Ubuntu 14.04 LTS and Mac OS X 10.9.5.
Status: RESOLVED → VERIFIED
Flags: qe-verify+
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.