1291658 - Marionette should not assume that there is always a processId in the capabilities available

Status: RESOLVED FIXED

(Testing :: Firefox UI Tests, defect, P1)

Description

[Florin Mezei, QA (:FlorinMezei)]

All ondemand update tests are failing for Firefox 49 beta 1: https://treeherder.mozilla.org/#/jobs?repo=mozilla-beta&revision=f21e48559ecd&group_state=expanded&filter-tier=3&filter-searchStr=Fxup-beta-cdntest(

This appears to be caused by fix for bug 1282570

Comment 1

[Henrik Skupin (:whimboo) [⌚️UTC+2] (away 07/24 - 08/10)]

I blame myself for this breakage in not having tested cross-version updates. The `processId` feature went in kinda earlier into marionette-server so that I simply forgot about it's first existence.

I'm going to fix that ASAP so we can unblock QA from running update tests for beta builds.

Comment 2

[Henrik Skupin (:whimboo) [⌚️UTC+2] (away 07/24 - 08/10)]

Attachment: Bug 1291658 - Marionette should not assume that there is always a processId in the capabilities available.

Before Firefox 49.0 there is no processId property available. Given that Firefox ui update tests
have to use the Marionette version from the post build also for the pre build, we currently fail
during in_app restarts for Firefox 48.0 and below.

Review commit: https://reviewboard.mozilla.org/r/68888/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/68888/

Comment 3

[David Burns :automatedtester]

Comment on attachment 8777299 [details]
Bug 1291658 - Marionette should not assume that there is always a processId in the capabilities available.

https://reviewboard.mozilla.org/r/68888/#review65954

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/mozilla-central/rev/8ab417619819
Marionette should not assume that there is always a processId in the capabilities available. r=automatedtester, a=tomcat

Comment 5

[Henrik Skupin (:whimboo) [⌚️UTC+2] (away 07/24 - 08/10)]

I landed the patch on mozilla-central after getting a+ from Carsten.

I will wait for results before requesting a backport to m-a and m-b.

Comment 6

[Henrik Skupin (:whimboo) [⌚️UTC+2] (away 07/24 - 08/10)]

Given that QA is blocked with the signoff for update tests on the beta-cdntest update channel, we would also have to backport the test-only patch to mozilla-aurora, and mozilla-beta. Carsten could you please do that ASAP? Thanks.

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/7ecbc0f93ff4

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-beta/rev/c40e04bf9297

Comment 9

[Intermittent Failures Robot]

221 automation job failures were associated with this bug yesterday.

Repository breakdown:
* mozilla-beta: 221

Platform breakdown:
* linux64: 30
* linux32: 30
* osx-10-9: 24
* osx-10-10: 24
* osx-10-11: 23
* windows7-64: 22
* windows8-64: 19
* windows7-32: 18
* windowsxp: 17
* windows8-32: 14

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1291658&startday=2016-08-03&endday=2016-08-03&tree=all

Comment 10

[Intermittent Failures Robot]

221 automation job failures were associated with this bug in the last 7 days.

Repository breakdown:
* mozilla-beta: 221

Platform breakdown:
* linux64: 30
* linux32: 30
* osx-10-9: 24
* osx-10-10: 24
* osx-10-11: 23
* windows7-64: 22
* windows8-64: 19
* windows7-32: 18
* windowsxp: 17
* windows8-32: 14

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1291658&startday=2016-08-01&endday=2016-08-07&tree=all