Closed Bug 1291658 Opened 4 years ago Closed 4 years ago

Marionette should not assume that there is always a processId in the capabilities available

Categories

(Testing :: Firefox UI Tests, defect, P1)

49 Branch
defect

Tracking

(firefox49 fixed, firefox50 fixed, firefox51 fixed)

RESOLVED FIXED
mozilla51
Tracking Status
firefox49 --- fixed
firefox50 --- fixed
firefox51 --- fixed

People

(Reporter: FlorinMezei, Assigned: whimboo)

References

Details

(Keywords: regression)

Attachments

(1 file)

I blame myself for this breakage in not having tested cross-version updates. The `processId` feature went in kinda earlier into marionette-server so that I simply forgot about it's first existence.

I'm going to fix that ASAP so we can unblock QA from running update tests for beta builds.
Assignee: nobody → hskupin
Status: NEW → ASSIGNED
Keywords: regression
Summary: Ondemand update tests failing after fix for bug 1282570 → Marionette should not assume that there is always a processId in the capabilities available
Severity: critical → normal
Priority: -- → P1
Before Firefox 49.0 there is no processId property available. Given that Firefox ui update tests
have to use the Marionette version from the post build also for the pre build, we currently fail
during in_app restarts for Firefox 48.0 and below.

Review commit: https://reviewboard.mozilla.org/r/68888/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/68888/
Attachment #8777299 - Flags: review?(dburns)
Comment on attachment 8777299 [details]
Bug 1291658 - Marionette should not assume that there is always a processId in the capabilities available.

https://reviewboard.mozilla.org/r/68888/#review65954
Attachment #8777299 - Flags: review?(dburns) → review+
Pushed by hskupin@mozilla.com:
https://hg.mozilla.org/mozilla-central/rev/8ab417619819
Marionette should not assume that there is always a processId in the capabilities available. r=automatedtester, a=tomcat
I landed the patch on mozilla-central after getting a+ from Carsten.

I will wait for results before requesting a backport to m-a and m-b.
Target Milestone: --- → mozilla51
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Given that QA is blocked with the signoff for update tests on the beta-cdntest update channel, we would also have to backport the test-only patch to mozilla-aurora, and mozilla-beta. Carsten could you please do that ASAP? Thanks.
Whiteboard: [checkin-needed-aurora][checkin-needed-beta]
https://hg.mozilla.org/releases/mozilla-aurora/rev/7ecbc0f93ff4
Whiteboard: [checkin-needed-aurora][checkin-needed-beta] → [checkin-needed-beta]
You need to log in before you can comment on or make changes to this bug.