Closed Bug 1291662 Opened 5 years ago Closed 5 years ago

Mark the flyweb system add-on as e10s compatible.

Categories

(Core :: Networking, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla51
Tracking Status
firefox51 --- fixed

People

(Reporter: standard8, Assigned: standard8)

References

Details

(Whiteboard: [necko-would-take])

Attachments

(1 file)

The flyweb rollout system add-on doesn't access web content, so we should be able to mark it as e10s compatible fairly easily I think.
Comment on attachment 8777298 [details]
Bug 1291662 - Mark the flyweb system add-on as e10s compatible as it already is.

Justin: FYI we're marking this e10s compatible, as I couldn't see anything in the code that would stop it being.

AFAICT there were no issues with doing this, I gave it a quick run, however as there's no tests it is a bit hard for me to be certain, so if you could give it a check as well that'd be useful.
Attachment #8777298 - Flags: feedback?(jdarcangelo)
Comment on attachment 8777298 [details]
Bug 1291662 - Mark the flyweb system add-on as e10s compatible as it already is.

https://reviewboard.mozilla.org/r/68892/#review65980

Thanks Mark. I'm surprised this wasn't already done - I was certain it was part of my feedback for the original FlyWeb patch...
Attachment #8777298 - Flags: review?(mconley) → review+
Component: General → Networking
Product: Firefox → Core
Comment on attachment 8777298 [details]
Bug 1291662 - Mark the flyweb system add-on as e10s compatible as it already is.

LGTM.

mconley: If you remember the l10n strings debacle we ran into while landing this, I believe we removed the e10s-compat flag as part of trying everything imaginable to figure out why we were getting test failures :-)

But yes, this add-on is e10s compatible and there's no reason this flag shouldn't have been there. Thanks!
Attachment #8777298 - Flags: feedback?(jdarcangelo) → feedback+
Great, thanks for the response, I'll get this landing.
Pushed by mbanner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/5f657b0bdfed
Mark the flyweb system add-on as e10s compatible as it already is. r=mconley
Whiteboard: [necko-would-take]
https://hg.mozilla.org/mozilla-central/rev/5f657b0bdfed
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla51
You need to log in before you can comment on or make changes to this bug.