1291662 - Mark the flyweb system add-on as e10s compatible.

Status: RESOLVED FIXED

(Core :: Networking, defect)

Description

[Mark Banner (:standard8)]

The flyweb rollout system add-on doesn't access web content, so we should be able to mark it as e10s compatible fairly easily I think.

Comment 1

[Mark Banner (:standard8)]

Attachment: Bug 1291662 - Mark the flyweb system add-on as e10s compatible as it already is.

Review commit: https://reviewboard.mozilla.org/r/68892/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/68892/

Comment 2

[Mark Banner (:standard8)]

Comment on attachment 8777298 [details]
Bug 1291662 - Mark the flyweb system add-on as e10s compatible as it already is.

Justin: FYI we're marking this e10s compatible, as I couldn't see anything in the code that would stop it being.

AFAICT there were no issues with doing this, I gave it a quick run, however as there's no tests it is a bit hard for me to be certain, so if you could give it a check as well that'd be useful.

Comment 3

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 8777298 [details]
Bug 1291662 - Mark the flyweb system add-on as e10s compatible as it already is.

https://reviewboard.mozilla.org/r/68892/#review65980

Thanks Mark. I'm surprised this wasn't already done - I was certain it was part of my feedback for the original FlyWeb patch...

Comment 4

[Justin D'Arcangelo [:justindarc]]

Comment on attachment 8777298 [details]
Bug 1291662 - Mark the flyweb system add-on as e10s compatible as it already is.

LGTM.

mconley: If you remember the l10n strings debacle we ran into while landing this, I believe we removed the e10s-compat flag as part of trying everything imaginable to figure out why we were getting test failures :-)

But yes, this add-on is e10s compatible and there's no reason this flag shouldn't have been there. Thanks!

Comment 5

[Mark Banner (:standard8)]

Great, thanks for the response, I'll get this landing.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5f657b0bdfed
Mark the flyweb system add-on as e10s compatible as it already is. r=mconley

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/5f657b0bdfed