Ship 1.4.4 of the Loop system add-on to the release population (via update mechanism)

RESOLVED FIXED in Firefox 48

Status

Hello (Loop)
Client
P1
normal
RESOLVED FIXED
a year ago
a year ago

People

(Reporter: standard8, Assigned: standard8)

Tracking

unspecified
mozilla48
Points:
---
Dependency tree / graph
Bug Flags:
qe-verify +

Firefox Tracking Flags

(firefox48+ fixed)

Details

(URL)

User Story

Suggested release notes:

- Banner on the Hello panel informing Hello users of upcoming service termination in FF49

Attachments

(1 attachment)

(Assignee)

Description

a year ago
1.4.x includes a banner notifying of the shut-down of Hello. We want to ship it to the release population.

Current suggested release notes in the user story.

This bug is for tracking the patches, xpis & the work.

Firefox 48 (release) currently has version 1.4.3 of the add-on. The version for this release is 1.4.4.

The only functional change included in this release is the addition of the banner (bug 1284423).
(Assignee)

Updated

a year ago
Assignee: nobody → standard8
Sylvestre, I added suggested release notes in the user story field, feel free to adjust if needed.

Updated

a year ago
User Story: (updated)
(Assignee)

Comment 2

a year ago
Bogdan, version 1.4.4 of the add-on is now available from AMO (and hence should be signed) for manual installing in FF 48 profiles (we'll only be releasing to 48.*)

https://addons.mozilla.org/en-US/firefox/addon/firefox-hello-beta/

I'm going to get the add-on signed for go faster soon and will get it up tomorrow if all goes well.
Flags: needinfo?(bogdan.maris)
(Assignee)

Updated

a year ago
Depends on: 1291753
(Assignee)

Comment 3

a year ago
I've updated Balrog and the update snippet is now on the release-sysaddon channel.
(In reply to Mark Banner (:standard8) from comment #2)
> Bogdan, version 1.4.4 of the add-on is now available from AMO (and hence
> should be signed) for manual installing in FF 48 profiles (we'll only be
> releasing to 48.*)
> 
> https://addons.mozilla.org/en-US/firefox/addon/firefox-hello-beta/
> 
> I'm going to get the add-on signed for go faster soon and will get it up
> tomorrow if all goes well.

Just finished testing on Firefox 48 across platforms, the update mechanism using release-sysaddon channel works as expected.
Flags: needinfo?(bogdan.maris)
(Assignee)

Comment 5

a year ago
[Tracking Requested - why for this release]: We need to land the add-on for 1.4.4 in mozilla-release so that its present for the 48.0.1 release.

I'm currently working on a patch.
tracking-firefox48: --- → ?
(Assignee)

Comment 6

a year ago
Created attachment 8781436 [details] [diff] [review]
1.4.4 patch for mozilla-release
(Assignee)

Comment 7

a year ago
Comment on attachment 8781436 [details] [diff] [review]
1.4.4 patch for mozilla-release

Approval Request Comment
[Feature/regressing bug #]: Firefox Hello 1.4.4 - Removal warning banner addition.
[User impact if declined]: The warning banner rolled out with yesterday's system update will disappear.
[Describe test coverage new/current, TreeHerder]: Has the normal test coverage.
[Risks and why]: Low, landing the shipped code in mozilla-release ahead of 48.0.1. 

Note: Its a big diff due to whitespace-only changes by one of the generating modules. I've gone through and visually spot checked that the changes we expect are there, and I've manually tested with a mozilla-release build.

[String/UUID change made/needed]: None
Attachment #8781436 - Flags: approval-mozilla-release?
(Assignee)

Comment 8

a year ago
qe-verify: Would be good to verify this in a release build when it lands/as part of the 48.0.1 release.
Flags: qe-verify+
Comment on attachment 8781436 [details] [diff] [review]
1.4.4 patch for mozilla-release

Taking it for 48.0.1
Attachment #8781436 - Flags: approval-mozilla-release? → approval-mozilla-release+
status-firefox48: --- → affected
tracking-firefox48: ? → +
(Assignee)

Comment 10

a year ago
https://hg.mozilla.org/releases/mozilla-release/rev/d086e0d56819
status-firefox48: affected → fixed
Target Milestone: --- → mozilla48
(Assignee)

Updated

a year ago
Status: NEW → RESOLVED
Last Resolved: a year ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.