1291703 - Ship 1.4.4 of the Loop system add-on to the release population (via update mechanism)

Status: RESOLVED FIXED

(Hello (Loop) :: Client, defect, P1)

Description

[Mark Banner (:standard8)]

1.4.x includes a banner notifying of the shut-down of Hello. We want to ship it to the release population.

Current suggested release notes in the user story.

This bug is for tracking the patches, xpis & the work.

Firefox 48 (release) currently has version 1.4.3 of the add-on. The version for this release is 1.4.4.

The only functional change included in this release is the addition of the banner (bug 1284423).

Comment 1

[Romain Testard [:RT]]

Sylvestre, I added suggested release notes in the user story field, feel free to adjust if needed.

Comment 2

[Mark Banner (:standard8)]

Bogdan, version 1.4.4 of the add-on is now available from AMO (and hence should be signed) for manual installing in FF 48 profiles (we'll only be releasing to 48.*)

https://addons.mozilla.org/en-US/firefox/addon/firefox-hello-beta/

I'm going to get the add-on signed for go faster soon and will get it up tomorrow if all goes well.

Comment 3

[Mark Banner (:standard8)]

I've updated Balrog and the update snippet is now on the release-sysaddon channel.

Comment 4

[Bogdan Maris, Desktop Test Engineering [OOO until Dec 16th]]

(In reply to Mark Banner (:standard8) from comment #2)
> Bogdan, version 1.4.4 of the add-on is now available from AMO (and hence
> should be signed) for manual installing in FF 48 profiles (we'll only be
> releasing to 48.*)
> 
> https://addons.mozilla.org/en-US/firefox/addon/firefox-hello-beta/
> 
> I'm going to get the add-on signed for go faster soon and will get it up
> tomorrow if all goes well.

Just finished testing on Firefox 48 across platforms, the update mechanism using release-sysaddon channel works as expected.

Comment 5

[Mark Banner (:standard8)]

[Tracking Requested - why for this release]: We need to land the add-on for 1.4.4 in mozilla-release so that its present for the 48.0.1 release.

I'm currently working on a patch.

Comment 6

[Mark Banner (:standard8)]

Attachment: 1.4.4 patch for mozilla-release

Comment 7

[Mark Banner (:standard8)]

Comment on attachment 8781436 [details] [diff] [review]
1.4.4 patch for mozilla-release

Approval Request Comment
[Feature/regressing bug #]: Firefox Hello 1.4.4 - Removal warning banner addition.
[User impact if declined]: The warning banner rolled out with yesterday's system update will disappear.
[Describe test coverage new/current, TreeHerder]: Has the normal test coverage.
[Risks and why]: Low, landing the shipped code in mozilla-release ahead of 48.0.1. 

Note: Its a big diff due to whitespace-only changes by one of the generating modules. I've gone through and visually spot checked that the changes we expect are there, and I've manually tested with a mozilla-release build.

[String/UUID change made/needed]: None

Comment 8

[Mark Banner (:standard8)]

qe-verify: Would be good to verify this in a release build when it lands/as part of the 48.0.1 release.

Comment 9

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8781436 [details] [diff] [review]
1.4.4 patch for mozilla-release

Taking it for 48.0.1

Comment 10

[Mark Banner (:standard8)]

https://hg.mozilla.org/releases/mozilla-release/rev/d086e0d56819