Background color of cancel button in permission dropdown on Windows is distinct from OS X and Linux

VERIFIED FIXED in Firefox 50

Status

()

defect
P2
normal
VERIFIED FIXED
3 years ago
3 years ago

People

(Reporter: rickychien, Assigned: rickychien)

Tracking

Trunk
Firefox 50
All
Windows
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox50 verified, firefox51 verified)

Details

Attachments

(1 attachment)

As Paul mentioned on https://bugzilla.mozilla.org/show_bug.cgi?id=1203292#c106.

Windows applied `background-color: ThreeDFace` at toolkit/themes/windows/global/button.css:13 and its style is distinct from OS X or Linux.
Paolo, 

here is one line patch for addressing incorrect button background color on Windows.
Please request uplift when fixed.
I suspect it's background-color that's defined on Windows, but will redirect the review to Jared.
Attachment #8777648 - Flags: review?(paolo.mozmail) → review?(jaws)
Comment on attachment 8777648 [details]
Bug 1291998 - Fix cancel button background color of permission dropdown on Windows

https://reviewboard.mozilla.org/r/69164/#review66752

::: browser/themes/shared/controlcenter/panel.inc.css:398
(Diff revision 1)
>    margin: 0;
>    border-width: 0;
>    border-radius: 50%;
>    min-width: 0;
>    padding: 2px;
> +  background-image: transparent;

transparent is not a valid value for background-image. Please test before requesting review, as this was obviously not tested.

The correct value, and verified locally by me, here is:
background-color: transparent;

r=me with that change
Attachment #8777648 - Flags: review?(jaws) → review+
Comment on attachment 8777648 [details]
Bug 1291998 - Fix cancel button background color of permission dropdown on Windows

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/69164/diff/1-2/
Attachment #8777648 - Flags: review+ → review?(paolo.mozmail)
Attachment #8777648 - Flags: review?(paolo.mozmail) → review+
Comment on attachment 8777648 [details]
Bug 1291998 - Fix cancel button background color of permission dropdown on Windows

Approval Request Comment
[Feature/regressing bug #]: bug 1203292
[User impact if declined]: cancel button on permission panel display incorrectly on Windonws.
[Describe test coverage new/current, TreeHerder]: no, styling issue
[Risks and why]: pretty low, one line CSS change
[String/UUID change made/needed]: no
Attachment #8777648 - Flags: approval-mozilla-aurora?
Pushed by cbook@mozilla.com:
https://hg.mozilla.org/integration/fx-team/rev/5e045cadaa9f
Fix cancel button background color of permission dropdown on Windows. r=paolo
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/5e045cadaa9f
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Comment on attachment 8777648 [details]
Bug 1291998 - Fix cancel button background color of permission dropdown on Windows

CSS only, fixes a regression, Aurora50+
Attachment #8777648 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Verified fixed FX 51.0a1 (2016-08-18), 50.0a2 (2016-08-18) Win 7
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.