1291998 - Background color of cancel button in permission dropdown on Windows is distinct from OS X and Linux

Status: VERIFIED FIXED

(Firefox :: General, defect, P2)

Description

[Ricky Chien [:rickychien] (inactive)]

As Paul mentioned on https://bugzilla.mozilla.org/show_bug.cgi?id=1203292#c106.

Windows applied `background-color: ThreeDFace` at toolkit/themes/windows/global/button.css:13 and its style is distinct from OS X or Linux.

Comment 1

[Ricky Chien [:rickychien] (inactive)]

Attachment: Bug 1291998 - Fix cancel button background color of permission dropdown on Windows

Review commit: https://reviewboard.mozilla.org/r/69164/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/69164/

Comment 2

[Ricky Chien [:rickychien] (inactive)]

Paolo, 

here is one line patch for addressing incorrect button background color on Windows.

Comment 3

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Please request uplift when fixed.

Comment 4

[:Paolo Amadini]

I suspect it's background-color that's defined on Windows, but will redirect the review to Jared.

Comment 5

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8777648 [details]
Bug 1291998 - Fix cancel button background color of permission dropdown on Windows

https://reviewboard.mozilla.org/r/69164/#review66752

::: browser/themes/shared/controlcenter/panel.inc.css:398
(Diff revision 1)
>    margin: 0;
>    border-width: 0;
>    border-radius: 50%;
>    min-width: 0;
>    padding: 2px;
> +  background-image: transparent;

transparent is not a valid value for background-image. Please test before requesting review, as this was obviously not tested.

The correct value, and verified locally by me, here is:
background-color: transparent;

r=me with that change

Comment 6

[Ricky Chien [:rickychien] (inactive)]

Comment on attachment 8777648 [details]
Bug 1291998 - Fix cancel button background color of permission dropdown on Windows

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/69164/diff/1-2/

Comment 7

[Ricky Chien [:rickychien] (inactive)]

Comment on attachment 8777648 [details]
Bug 1291998 - Fix cancel button background color of permission dropdown on Windows

Approval Request Comment
[Feature/regressing bug #]: bug 1203292
[User impact if declined]: cancel button on permission panel display incorrectly on Windonws.
[Describe test coverage new/current, TreeHerder]: no, styling issue
[Risks and why]: pretty low, one line CSS change
[String/UUID change made/needed]: no

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/fx-team/rev/5e045cadaa9f
Fix cancel button background color of permission dropdown on Windows. r=paolo

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/5e045cadaa9f

Comment 10

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Comment on attachment 8777648 [details]
Bug 1291998 - Fix cancel button background color of permission dropdown on Windows

CSS only, fixes a regression, Aurora50+

Comment 11

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/f5a9d33557dd

Comment 12

[Paul Silaghi, QA [:pauly]]

Verified fixed FX 51.0a1 (2016-08-18), 50.0a2 (2016-08-18) Win 7