Reduce size of ffmpeg code where possible

RESOLVED FIXED in Firefox 51

Status

()

Core
Audio/Video: Playback
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: jya, Assigned: jya)

Tracking

(Blocks: 1 bug)

unspecified
mozilla51
Points:
---

Firefox Tracking Flags

(firefox51 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Description

2 years ago
There's a fair amount of strings and code we could get rid of, all those related to the use of user configurable options. None of which are being used as we don't let the user configure anything.

We could get rid of a fair bit hopefully.
(Assignee)

Comment 1

2 years ago
Created attachment 8777689 [details]
Bug 1292039: [ffmpeg] P1. Remove unused options and dictionary features. .

Saving is disappointing, only 41kiB out of a 2222kiB

Review commit: https://reviewboard.mozilla.org/r/69202/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/69202/
Attachment #8777689 - Flags: review?(ajones)
(In reply to Jean-Yves Avenard [:jya] from comment #1)
> Saving is disappointing, only 41kiB out of a 2222kiB

40K is still a worthwhile win, especially since it didn't require that much work.  Thanks for looking at this!
Comment on attachment 8777689 [details]
Bug 1292039: [ffmpeg] P1. Remove unused options and dictionary features. .

https://reviewboard.mozilla.org/r/69202/#review66546
Attachment #8777689 - Flags: review?(ajones) → review+

Comment 4

2 years ago
Pushed by jyavenard@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e99d6caa3a37
[ffmpeg] P1. Remove unused options and dictionary features. r=kentuckyfriedtakahe.

Comment 5

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/e99d6caa3a37
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox51: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla51
You need to log in before you can comment on or make changes to this bug.