Closed Bug 1292039 Opened 4 years ago Closed 4 years ago

Reduce size of ffmpeg code where possible

Categories

(Core :: Audio/Video: Playback, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla51
Tracking Status
firefox51 --- fixed

People

(Reporter: jya, Assigned: jya)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

There's a fair amount of strings and code we could get rid of, all those related to the use of user configurable options. None of which are being used as we don't let the user configure anything.

We could get rid of a fair bit hopefully.
Saving is disappointing, only 41kiB out of a 2222kiB

Review commit: https://reviewboard.mozilla.org/r/69202/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/69202/
Attachment #8777689 - Flags: review?(ajones)
(In reply to Jean-Yves Avenard [:jya] from comment #1)
> Saving is disappointing, only 41kiB out of a 2222kiB

40K is still a worthwhile win, especially since it didn't require that much work.  Thanks for looking at this!
Comment on attachment 8777689 [details]
Bug 1292039: [ffmpeg] P1. Remove unused options and dictionary features. .

https://reviewboard.mozilla.org/r/69202/#review66546
Attachment #8777689 - Flags: review?(ajones) → review+
Pushed by jyavenard@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e99d6caa3a37
[ffmpeg] P1. Remove unused options and dictionary features. r=kentuckyfriedtakahe.
https://hg.mozilla.org/mozilla-central/rev/e99d6caa3a37
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla51
You need to log in before you can comment on or make changes to this bug.