remove lazy loading from inspector

RESOLVED FIXED in Firefox 51

Status

DevTools
Framework
P1
enhancement
RESOLVED FIXED
2 years ago
a month ago

People

(Reporter: tromey, Assigned: tromey)

Tracking

unspecified
Firefox 51
Dependency tree / graph
Bug Flags:
qe-verify -

Firefox Tracking Flags

(firefox51 fixed)

Details

(Whiteboard: [reserve-html])

MozReview Requests

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Description

2 years ago
Investigation in bug 1278625 showed that lazy requires in the inspector
generally don't do anything -- the referenced modules are all loaded
elsewhere during inspector startup.  So, let's remove these.
(Assignee)

Comment 1

2 years ago
After this patch there will still be some uses of lazyGetter et al.
However, these are all slated for removal by other de-chrome-ification bugs;
so I didn't bother touching them here.

Updated

2 years ago
Iteration: --- → 51.1 - Aug 15
Flags: qe-verify-
Priority: -- → P1
Whiteboard: [devtools-html] → [reserve-html]
(Assignee)

Comment 2

2 years ago
Created attachment 8777850 [details]
Bug 1292184 - remove lazy requires from inspector;

Review commit: https://reviewboard.mozilla.org/r/69296/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/69296/
Attachment #8777850 - Flags: review?(jlong)
Comment on attachment 8777850 [details]
Bug 1292184 - remove lazy requires from inspector;

https://reviewboard.mozilla.org/r/69296/#review66462

Nice, this looks good
Attachment #8777850 - Flags: review?(jlong) → review+

Comment 4

2 years ago
Pushed by ttromey@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/aaa21719d503
remove lazy requires from inspector; r=jlongster

Comment 5

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/aaa21719d503
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
status-firefox51: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 51

Updated

a month ago
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.