|Submitter||Diff||Changes||Open Issues||Last Updated|
|Error loading review requests:|
58 bytes, text/x-review-board-request
|Details | Review|
Investigation in bug 1278625 showed that lazy requires in the inspector generally don't do anything -- the referenced modules are all loaded elsewhere during inspector startup. So, let's remove these.
After this patch there will still be some uses of lazyGetter et al. However, these are all slated for removal by other de-chrome-ification bugs; so I didn't bother touching them here.
Iteration: --- → 51.1 - Aug 15
Priority: -- → P1
Whiteboard: [devtools-html] → [reserve-html]
Created attachment 8777850 [details] Bug 1292184 - remove lazy requires from inspector; Review commit: https://reviewboard.mozilla.org/r/69296/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/69296/
Attachment #8777850 - Flags: review?(jlong)
Comment on attachment 8777850 [details] Bug 1292184 - remove lazy requires from inspector; https://reviewboard.mozilla.org/r/69296/#review66462 Nice, this looks good
Attachment #8777850 - Flags: review?(jlong) → review+
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/autoland/rev/aaa21719d503 remove lazy requires from inspector; r=jlongster
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
status-firefox51: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 51
You need to log in before you can comment on or make changes to this bug.