Closed
Bug 1292184
Opened 8 years ago
Closed 8 years ago
remove lazy loading from inspector
Categories
(DevTools :: Framework, enhancement, P1)
DevTools
Framework
Tracking
(firefox51 fixed)
Tracking | Status | |
---|---|---|
firefox51 | --- | fixed |
People
(Reporter: tromey, Assigned: tromey)
References
Details
(Whiteboard: [reserve-html])
Attachments
(1 file)
Investigation in bug 1278625 showed that lazy requires in the inspector
generally don't do anything -- the referenced modules are all loaded
elsewhere during inspector startup. So, let's remove these.
Assignee | ||
Comment 1•8 years ago
|
||
After this patch there will still be some uses of lazyGetter et al.
However, these are all slated for removal by other de-chrome-ification bugs;
so I didn't bother touching them here.
Updated•8 years ago
|
Iteration: --- → 51.1 - Aug 15
Flags: qe-verify-
Priority: -- → P1
Whiteboard: [devtools-html] → [reserve-html]
Assignee | ||
Comment 2•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/69296/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/69296/
Attachment #8777850 -
Flags: review?(jlong)
Comment 3•8 years ago
|
||
Comment on attachment 8777850 [details]
Bug 1292184 - remove lazy requires from inspector;
https://reviewboard.mozilla.org/r/69296/#review66462
Nice, this looks good
Attachment #8777850 -
Flags: review?(jlong) → review+
Pushed by ttromey@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/aaa21719d503
remove lazy requires from inspector; r=jlongster
Comment 5•8 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox51:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 51
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•