Closed Bug 1292188 Opened 8 years ago Closed 8 years ago

Automatically retrieve l10n changesets from elmo

Categories

(Release Engineering :: Applications: Shipit, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: rail, Assigned: jlorenzo)

References

Details

Attachments

(1 file)

50 bytes, text/x-github-pull-request
rail
: review+
Details | Review
This page contains links to l10n changesets for different products:

https://l10n.mozilla.org/shipping/drivers

Ship-it should:
* Fetch the data from elmo automatically (frontend or backend)
* Hide the l10n textarea and make it editable in advanced mode (just in case we have issues with the data)
* Remove the l10n dashboard check: bug 1290485
* Build2 to reuse build1 l10n data by default with ability to force refresh
Assignee: nobody → jlorenzo
Attached file PR
Status: NEW → ASSIGNED
Depends on: 1290485
Blocks: 1294107
Comment on attachment 8779730 [details] [review]
PR

> Ship-it should:
> * Fetch the data from elmo automatically (frontend or backend)
Done on the client side. I added tests for `getElmoUrl()`, but I haven't for `populateL10nChangesets()` which performs the async request and the UI manipulation. The easiest way to test it would be to use a mocking library (like sinon.js). At the first glance, I didn't want to increase the numbers of external libs, but if you're okay with me adding it, I'll be pleased to do so (probably in a follow up).

> * Hide the l10n textarea and make it editable in advanced mode (just in case we have issues with the data)
Done. The field remain disabled while the Ajax request is still pending.

> * Remove the l10n dashboard check: bug 1290485
Sylvestre has a patch there. I'll wait until this bug lands.

> * Build2 to reuse build1 l10n data by default with ability to force refresh
Discussed with :rail, it's better in a follow up. See bug 1294107.
Attachment #8779730 - Flags: review?(sledru)
Attachment #8779730 - Flags: review?(rail)
Attachment #8779730 - Flags: review?(rail) → review+
Landed at https://github.com/mozilla-releng/ship-it/commit/55265acb74d5a9dd2740a0b29397628b8231fb1e
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Comment on attachment 8779730 [details] [review]
PR

You are moving too fast for me!
Attachment #8779730 - Flags: review?(sledru)
Blocks: 1297011
Blocks: 1321335
Component: Applications: ShipIt (backend) → Applications: ShipIt
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: