Status
People
(Reporter: tromey, Assigned: tromey)
Tracking
Firefox Tracking Flags
(firefox51 fixed)
Details
(Whiteboard: [reserve-html])
Attachments
(1 attachment)
Inspector startup require devtools/shared/layout/utils.js. It's used directly by the inspector for scrollIntoViewIfNeeded, but perhaps also indirectly as well. This file requires "chrome", so it needs some cleanup for de-chrome-ficiation. It also indirectly require chrome for "memoize", so this dependency probably needs to be broken. And, it uses a questionable lazy require of something from server -- but just to re-export a function, so perhaps this bit can be removed entirely.
|
||
Updated•2 years ago
|
||
Flags: qe-verify-
Priority: -- → P2
Whiteboard: [devtools-html] → [reserve-html]
|
(Assignee) | |
Comment 1•2 years ago
|
||
This is only used for a single function, which I think we can get another way.
Assignee: nobody → ttromey
Status: NEW → ASSIGNED
|
|
||
Updated•2 years ago
|
||
Iteration: --- → 51.2 - Aug 29
Priority: P2 → P1
|
|
(Assignee) | |
Comment 2•2 years ago
|
||
Actuall afaict that function is already content-safe, so just moving it to its own module should suffice.
| Comment hidden (mozreview-request) |
|
||
Comment 4•2 years ago
|
||
| mozreview-review | ||
Comment on attachment 8782069 [details] Bug 1292242 - move scrollIntoViewIfNeeded to its own module; https://reviewboard.mozilla.org/r/72330/#review69938 ::: devtools/shared/layout/scroll.js:1 (Diff revision 1) > +/* This Source Code Form is subject to the terms of the Mozilla Public This file could be somewhere in client/ which would also remove another shared/ dependency. I don't see a benefit to keeping it in the shared/layout/ folder. Maybe client/shared?
Attachment #8782069 -
Flags: review?(bgrinstead)
| Comment hidden (mozreview-request) |
|
|
||
Comment 6•2 years ago
|
||
| mozreview-review | ||
Comment on attachment 8782069 [details] Bug 1292242 - move scrollIntoViewIfNeeded to its own module; https://reviewboard.mozilla.org/r/72330/#review69976
Attachment #8782069 -
Flags: review?(bgrinstead) → review+
Pushed by ttromey@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/5ad72122cba9 move scrollIntoViewIfNeeded to its own module; r=bgrins
|
||
Comment 8•2 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/5ad72122cba9
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
status-firefox51: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 51
|
||
Updated•5 months ago
|
||
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•