1292242 - deal with devtools/shared/layout/utils.js

Status: RESOLVED FIXED

(DevTools :: Framework, enhancement, P1)

Description

[Tom Tromey :tromey]

Inspector startup require devtools/shared/layout/utils.js.
It's used directly by the inspector for scrollIntoViewIfNeeded,
but perhaps also indirectly as well.
This file requires "chrome", so it needs some cleanup for
de-chrome-ficiation.
It also indirectly require chrome for "memoize", so this dependency
probably needs to be broken.
And, it uses a questionable lazy require of something from server -- but
just to re-export a function, so perhaps this bit can be removed entirely.

Comment 1

[Tom Tromey :tromey]

This is only used for a single function, which I think we can get another way.

Comment 2

[Tom Tromey :tromey]

Actuall afaict that function is already content-safe, so just moving it to its own module
should suffice.

Comment 3

[Tom Tromey :tromey]

Attachment: Bug 1292242 - move scrollIntoViewIfNeeded to its own module;

Review commit: https://reviewboard.mozilla.org/r/72330/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/72330/

Comment 4

[Brian Grinstead [:bgrins]]

Comment on attachment 8782069 [details]
Bug 1292242 - move scrollIntoViewIfNeeded to its own module;

https://reviewboard.mozilla.org/r/72330/#review69938

::: devtools/shared/layout/scroll.js:1
(Diff revision 1)
> +/* This Source Code Form is subject to the terms of the Mozilla Public

This file could be somewhere in client/ which would also remove another shared/ dependency.  I don't see a benefit to keeping it in the shared/layout/ folder.  Maybe client/shared?

Comment 5

[Tom Tromey :tromey]

Comment on attachment 8782069 [details]
Bug 1292242 - move scrollIntoViewIfNeeded to its own module;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/72330/diff/1-2/

Comment 6

[Brian Grinstead [:bgrins]]

Comment on attachment 8782069 [details]
Bug 1292242 - move scrollIntoViewIfNeeded to its own module;

https://reviewboard.mozilla.org/r/72330/#review69976

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5ad72122cba9
move scrollIntoViewIfNeeded to its own module; r=bgrins

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/5ad72122cba9