Closed Bug 1292242 Opened 4 years ago Closed 4 years ago
deal with devtools/shared/layout/utils
58 bytes, text/x-review-board-request
Inspector startup require devtools/shared/layout/utils.js. It's used directly by the inspector for scrollIntoViewIfNeeded, but perhaps also indirectly as well. This file requires "chrome", so it needs some cleanup for de-chrome-ficiation. It also indirectly require chrome for "memoize", so this dependency probably needs to be broken. And, it uses a questionable lazy require of something from server -- but just to re-export a function, so perhaps this bit can be removed entirely.
Priority: -- → P2
Whiteboard: [devtools-html] → [reserve-html]
This is only used for a single function, which I think we can get another way.
Assignee: nobody → ttromey
Status: NEW → ASSIGNED
Actuall afaict that function is already content-safe, so just moving it to its own module should suffice.
Comment on attachment 8782069 [details] Bug 1292242 - move scrollIntoViewIfNeeded to its own module; https://reviewboard.mozilla.org/r/72330/#review69938 ::: devtools/shared/layout/scroll.js:1 (Diff revision 1) > +/* This Source Code Form is subject to the terms of the Mozilla Public This file could be somewhere in client/ which would also remove another shared/ dependency. I don't see a benefit to keeping it in the shared/layout/ folder. Maybe client/shared?
Attachment #8782069 - Flags: review?(bgrinstead)
Comment on attachment 8782069 [details] Bug 1292242 - move scrollIntoViewIfNeeded to its own module; https://reviewboard.mozilla.org/r/72330/#review69976
Attachment #8782069 - Flags: review?(bgrinstead) → review+
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/autoland/rev/5ad72122cba9 move scrollIntoViewIfNeeded to its own module; r=bgrins
You need to log in before you can comment on or make changes to this bug.