Closed Bug 1292245 Opened 3 years ago Closed 3 years ago

clean up some trivial require("chrome") uses

Categories

(DevTools :: Framework, enhancement, P1)

enhancement

Tracking

(firefox51 fixed)

RESOLVED FIXED
Firefox 51
Iteration:
51.1 - Aug 15
Tracking Status
firefox51 --- fixed

People

(Reporter: tromey, Assigned: tromey)

References

Details

(Whiteboard: [reserve-html])

Attachments

(1 file)

There are a couple of trivial require("chrome") removals to be done
in modules required during inspector startup; namely in async-utils.js
and indentation.js.  Neither of these imports is actually used.
Iteration: --- → 51.1 - Aug 15
Flags: qe-verify-
Priority: -- → P1
Whiteboard: [devtools-html] → [reserve-html]
Comment on attachment 8777902 [details]
Bug 1292245 - remove some unnecessary imports of chrome from devtools;

https://reviewboard.mozilla.org/r/69310/#review66466

LGTM
Attachment #8777902 - Flags: review?(gtatum) → review+
Pushed by ttromey@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/192132a4cbc7
remove some unnecessary imports of chrome from devtools; r=gregtatum
https://hg.mozilla.org/mozilla-central/rev/192132a4cbc7
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 51
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.