Closed Bug 1292289 Opened 5 years ago Closed 5 years ago

Include xpcprivate.h in less places

Categories

(Core :: XPConnect, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla51
Tracking Status
firefox51 --- fixed

People

(Reporter: mccr8, Assigned: mccr8)

Details

Attachments

(3 files)

I was working on some patches recently that used xpcprivate.h, and that requires building a decent number of files, which is annoying. A few of those can be removed, which eliminates a few files from needing a rebuild.
This file is included in caps/, but it only uses generic JS things,
aside from a macro.

AccessCheck.cpp was bootlegging xpcprivate.h.

Review commit: https://reviewboard.mozilla.org/r/69336/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/69336/
Attachment #8777921 - Flags: review?(mrbkap)
Attachment #8777922 - Flags: review?(mrbkap)
Attachment #8777923 - Flags: review?(mrbkap)
Also remove some unused nsIXPConnect headers.

With the prior patch and this patch, touching xpcprivate.h does not
require rebuilding the caps directory.

Review commit: https://reviewboard.mozilla.org/r/69338/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/69338/
This file only uses functions on nsIXPConnect, so it can get it from
nsContentUtils and stop including xpcprivate.h, which eliminates
another file from being rebuilt when xpcprivate.h gets touched.

Review commit: https://reviewboard.mozilla.org/r/69340/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/69340/
The remainder of the includes are in dom/base and dom/bindings and it will be harder to remove the dependency, so I didn't work on it.
Comment on attachment 8777921 [details]
Bug 1292289, part 1 - Stop unnecessarily using xpcprivate in XPCWrapper.h.

https://reviewboard.mozilla.org/r/69336/#review66480
Attachment #8777921 - Flags: review?(mrbkap) → review+
Comment on attachment 8777922 [details]
Bug 1292289, part 2 - Remove includes of xpcprivate.h in caps/.

https://reviewboard.mozilla.org/r/69338/#review66482
Attachment #8777922 - Flags: review?(mrbkap) → review+
Comment on attachment 8777923 [details]
Bug 1292289, part 3 - Remove dependency of Console on xpcprivate.h.

https://reviewboard.mozilla.org/r/69340/#review66484
Attachment #8777923 - Flags: review?(mrbkap) → review+
Pushed by amccreight@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/3df8701bddbe
part 1 - Stop unnecessarily using xpcprivate in XPCWrapper.h. r=mrbkap
https://hg.mozilla.org/integration/autoland/rev/998eab06f121
part 2 - Remove includes of xpcprivate.h in caps/. r=mrbkap
https://hg.mozilla.org/integration/autoland/rev/e02666d4e3e8
part 3 - Remove dependency of Console on xpcprivate.h. r=mrbkap
You need to log in before you can comment on or make changes to this bug.