1292364 - Since jsmime.js, no longer possible to use Disposition-Notification-To in mail.compose.other.header (port bug 1250376 to SeaMonkey)

Status: RESOLVED FIXED

(SeaMonkey :: MailNews: Composition, defect)

Description

[rsx11m]

+++ This bug was initially created as a clone of Bug #1250376 +++

A long, long time ago, in a galaxy before jsmime.js was integrated into the mail composition code path, I provided these instructions to the users of my Send Later add-on for how to add a Disposition-Notification-To header manually to outgoing messages:

1. Open the Thunderbird options dialog with Tools > Options… or Edit > Preferences…
2. Click “Advanced” and then “Config Editor…” and click the “I’ll be careful, I promise!” button if it asks you to.
3. Enter “mail.compose.other.header” in the filter box.
4. Double-click on the mail.compose.other.header setting and set it to “Disposition-Notification-To”. If it already has a non-empty value, add a comma and then “Disposition-Notification-To” to the end of it.
5. Quit from and restart Thunderbird.
6. When you are composing a message for which you want a return receipt and which you want to schedule to be sent later, then click on an empty line in the message header in the compose window, select “Disposition-Notification-To” in the drop-down, and then enter your email address as the value of the header.

This worked just fine. Now, it does not. When you follow step 6 above and then try to save the resulting draft, you get this:

JavaScript error: resource:///modules/jsmime.jsm -> resource:///modules/jsmime/jsmime.js, line 3074: TypeError: invalid 'in' operand addr

I don't know if the attached patch is the _correct_ fix to this problem (in fact, I'd wager good money it isn't), but it works, and at least points to the source of the problem.

I suspect bug 1180209 may be related to this.

Comment 1

[rsx11m]

Attachment: One-line patch

Fairly direct port of bug 1250376 attachment 8775553 [details] [diff] [review].

Comment 2

[Philip Chee]

Comment on attachment 8778000 [details] [diff] [review]
One-line patch

a=me for checkin

Comment 3

[rsx11m]

http://hg.mozilla.org/comm-central/rev/230c4f660356

Comment 4

[rsx11m]

Comment on attachment 8778000 [details] [diff] [review]
One-line patch

[Approval Request Comment]
Regression caused by (bug #): JS Mime
User impact if declined: custom headers aren't available in composition window
Testing completed (on m-c, etc.): works on c-c, landed on c-esr45 for Thunderbird
Risk to taking this patch (and alternatives if risky): low
String changes made by this patch: none

Comment 5

[Ian Neal]

Comment on attachment 8778000 [details] [diff] [review]
One-line patch

a=me

Comment 6

[rsx11m]

http://hg.mozilla.org/releases/comm-aurora/rev/71979f61a7d4
http://hg.mozilla.org/releases/comm-beta/rev/44c2367de8d1
http://hg.mozilla.org/releases/comm-release/rev/8c1e5a12bdf9