Closed
Bug 1292476
Opened 8 years ago
Closed 8 years ago
Use nsIIDNSerice.Normalize instead of nsIUnicodeNormalizer on NPNVdocumentOrigin
Categories
(Core Graveyard :: Plug-ins, defect, P3)
Tracking
(firefox51 wontfix, firefox52 fixed)
RESOLVED
FIXED
mozilla52
People
(Reporter: m_kato, Assigned: m_kato)
References
Details
Attachments
(1 file)
Actually nsIUnicodeNormalization is for URL nomalization. But we have new Nomalization API in nsIIDNService that is RFC compatible / IDN 2008 by ICU So we should use nsIIDNService for NPNVdocumentOrigin.
|
Assignee | |
Updated•8 years ago
|
Summary: Use nsIIDNSerice.Normalize instead of nsIUnicodeNormalization on NPNVdocumentOrigin → Use nsIIDNSerice.Normalize instead of nsIUnicodeNormalizer on NPNVdocumentOrigin
|
||
Updated•8 years ago
|
Priority: -- → P3
|
||
Comment 1•8 years ago
|
||
Something like this? It's a bit ugly with all the encoding form conversions, but I don't suppose this API is so very perf-critical that it really matters -- and it won't be handling hugely long strings, either.
Attachment #8796135 -
Flags: review?(m_kato)
|
|
Assignee | |
Updated•8 years ago
|
Attachment #8796135 -
Flags: review?(m_kato) → review+
|
|
||
Comment 2•8 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/46527b8c5bc2acd3a74b843a86c3cac9445746e8 Bug 1292476 - Replace use of nsIUnicodeNormalizer with nsIIDNService in the implementation of NPNVdocumentOrigin. r=m_kato
|
||
Comment 3•8 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/46527b8c5bc2
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox52:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
|
||
Comment 4•8 years ago
|
||
Mark 51 as won't fix. If it's worth uplifting to 51, feel free to nominate it.
|
||
Updated•2 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•