Closed Bug 1292500 Opened 3 years ago Closed 3 years ago

"Camera is on" notification stays after backgrounding Fennec

Categories

(Firefox for Android :: Audio/Video, defect, P1)

ARM
Android
defect

Tracking

()

VERIFIED FIXED
Firefox 51
Iteration:
1.3
Tracking Status
firefox48 --- wontfix
firefox49 --- verified
fennec 49+ ---
firefox50 --- verified
firefox51 --- verified

People

(Reporter: gcp, Assigned: sebastian)

References

Details

(Whiteboard: [TPE-1] [MobileAS] )

Attachments

(1 file)

+++ This bug was initially created as a clone of Bug #1290075 +++

Nexus 4, Android 5.0.1
Galaxy S7, Android 6

1) Go to https://mozilla.github.io/webrtc-landing/gum_test.html
2) Click video
3) Tap home button
4) Observe that "Fennec - Camera is on" message stays

Because of bug 874572 this is unexpected.

I can confirm that on the S7 the camera app still works. This might be either:
a) The camera is shut down and our UI is wrong
b) Internal improvements in Android that allow better camera sharing
Summary: Can't open audio inputs via GetUserMedia() in Android (or desktop without full_duplex) → "Camera is on" notification stays after backgrounding Fennec
I just confirmed that the camera does shutdown.  So this is a UI bug.

gcp -- Can you change the category of this to Fennec UI and needinfo the right person/people?
Flags: needinfo?(gpascutto)
Component: WebRTC: Audio/Video → Audio/Video
Flags: needinfo?(gpascutto)
Product: Core → Firefox for Android
I see this to too with a Sony Z3C - Android 5.1.1.

And it seems to happen on all channels, including the release version (48.0).
tracking-fennec: --- → ?
Whiteboard: [TPE-1]
Instead of allowing the notification to persist, we should hide the notification.
Assignee: nobody → s.kaspari
tracking-fennec: ? → 49+
Looking at the code it seems this was just never implemented (and is not a regression). VideoCaptureAndroid.onPause() and VideoCaptureAndroid.onResume() are triggered by GeckoApp to stop/resume capturing video when the app is in background/foreground. However WebrtcUI.js, which handles showing/removing the notification, does not receive any events to know about those state changes.
Comment on attachment 8783918 [details]
Bug 1292500 - Notify WebrtcUI when video capturing is paused/resumed.

https://reviewboard.mozilla.org/r/73574/#review71378
Attachment #8783918 - Flags: review?(gpascutto) → review+
Pushed by s.kaspari@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/fd2938bd35de
Notify WebrtcUI when video capturing is paused/resumed. r=gcp
https://hg.mozilla.org/mozilla-central/rev/fd2938bd35de
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 51
Whiteboard: [TPE-1] → [TPE-1] [MobileAS]
Too late for 48 but do we want to uplift that to 49 & 50? Thanks
Flags: needinfo?(s.kaspari)
(In reply to Sylvestre Ledru [:sylvestre] from comment #9)
> Too late for 48 but do we want to uplift that to 49 & 50? Thanks

Yeah, risk should be low. I'll request.
Flags: needinfo?(s.kaspari)
Comment on attachment 8783918 [details]
Bug 1292500 - Notify WebrtcUI when video capturing is paused/resumed.

Approval Request Comment

[Feature/regressing bug #]: A long time ago we implemented that the camera gets released when Firefox is in the background (bug 874572) so that other apps could access the camera. However we still show the "recording" notification while the app is in the background.

[User impact if declined]: User thinks Firefox is still recording while the app is in the background.

[Describe test coverage new/current, TreeHerder]: Manual testing with the help of https://mozilla.github.io/webrtc-landing/gum_test.html
 
[Risks and why]: Low. The patch introduces new events that notify the UI code to hide/show the notification. This shouldn't affect other parts of the code.

[String/UUID change made/needed]: -
Attachment #8783918 - Flags: approval-mozilla-beta?
Attachment #8783918 - Flags: approval-mozilla-aurora?
Comment on attachment 8783918 [details]
Bug 1292500 - Notify WebrtcUI when video capturing is paused/resumed.

Hide incorrect notification UI for camera. OK to uplift for beta 7 or 8.
Attachment #8783918 - Flags: approval-mozilla-beta?
Attachment #8783918 - Flags: approval-mozilla-beta+
Attachment #8783918 - Flags: approval-mozilla-aurora?
Attachment #8783918 - Flags: approval-mozilla-aurora+
This is now fixed. The notification is now dismissed. 
Verified on Nexus 5x (Android 6.0.1) with Fennec 49 Beta 8, Aurora 50.0a2 (2016-08-29, Nightly 51.0a1 (2016-08-29).
Iteration: --- → 1.3
You need to log in before you can comment on or make changes to this bug.