1292500 - "Camera is on" notification stays after backgrounding Fennec

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Audio/Video, defect, P1)

Description

[Gian-Carlo Pascutto [:gcp]]

+++ This bug was initially created as a clone of Bug #1290075 +++

Nexus 4, Android 5.0.1
Galaxy S7, Android 6

1) Go to https://mozilla.github.io/webrtc-landing/gum_test.html
2) Click video
3) Tap home button
4) Observe that "Fennec - Camera is on" message stays

Because of bug 874572 this is unexpected.

I can confirm that on the S7 the camera app still works. This might be either:
a) The camera is shut down and our UI is wrong
b) Internal improvements in Android that allow better camera sharing

Comment 1

[Maire Reavy [:mreavy]]

I just confirmed that the camera does shutdown.  So this is a UI bug.

gcp -- Can you change the category of this to Fennec UI and needinfo the right person/people?

Comment 2

[Sebastian Kaspari (:sebastian; :pocmo)]

I see this to too with a Sony Z3C - Android 5.1.1.

And it seems to happen on all channels, including the release version (48.0).

Comment 3

[Anthony Lam (:antlam) Find me, @antlam on Slack!]

Instead of allowing the notification to persist, we should hide the notification.

Comment 4

[Sebastian Kaspari (:sebastian; :pocmo)]

Looking at the code it seems this was just never implemented (and is not a regression). VideoCaptureAndroid.onPause() and VideoCaptureAndroid.onResume() are triggered by GeckoApp to stop/resume capturing video when the app is in background/foreground. However WebrtcUI.js, which handles showing/removing the notification, does not receive any events to know about those state changes.

Comment 5

[Sebastian Kaspari (:sebastian; :pocmo)]

Attachment: Bug 1292500 - Notify WebrtcUI when video capturing is paused/resumed.

Review commit: https://reviewboard.mozilla.org/r/73574/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/73574/

Comment 6

[Gian-Carlo Pascutto [:gcp]]

Comment on attachment 8783918 [details]
Bug 1292500 - Notify WebrtcUI when video capturing is paused/resumed.

https://reviewboard.mozilla.org/r/73574/#review71378

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fd2938bd35de
Notify WebrtcUI when video capturing is paused/resumed. r=gcp

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/fd2938bd35de

Comment 9

[Sylvestre Ledru [:Sylvestre]]

Too late for 48 but do we want to uplift that to 49 & 50? Thanks

Comment 10

[Sebastian Kaspari (:sebastian; :pocmo)]

(In reply to Sylvestre Ledru [:sylvestre] from comment #9)
> Too late for 48 but do we want to uplift that to 49 & 50? Thanks

Yeah, risk should be low. I'll request.

Comment 11

[Sebastian Kaspari (:sebastian; :pocmo)]

Comment on attachment 8783918 [details]
Bug 1292500 - Notify WebrtcUI when video capturing is paused/resumed.

Approval Request Comment

[Feature/regressing bug #]: A long time ago we implemented that the camera gets released when Firefox is in the background (bug 874572) so that other apps could access the camera. However we still show the "recording" notification while the app is in the background.

[User impact if declined]: User thinks Firefox is still recording while the app is in the background.

[Describe test coverage new/current, TreeHerder]: Manual testing with the help of https://mozilla.github.io/webrtc-landing/gum_test.html
 
[Risks and why]: Low. The patch introduces new events that notify the UI code to hide/show the notification. This shouldn't affect other parts of the code.

[String/UUID change made/needed]: -

Comment 12

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 8783918 [details]
Bug 1292500 - Notify WebrtcUI when video capturing is paused/resumed.

Hide incorrect notification UI for camera. OK to uplift for beta 7 or 8.

Comment 13

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/e29cdbb036ab

Comment 14

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/f93f04ae8b36

Comment 15

[Ioana Chiorean]

This is now fixed. The notification is now dismissed. 
Verified on Nexus 5x (Android 6.0.1) with Fennec 49 Beta 8, Aurora 50.0a2 (2016-08-29, Nightly 51.0a1 (2016-08-29).