Closed Bug 1292574 Opened 4 years ago Closed 4 years ago

change CSS from a module to a global in builtin-modules.js

Categories

(DevTools :: Framework, enhancement, P1)

enhancement

Tracking

(firefox51 fixed)

RESOLVED FIXED
Firefox 51
Iteration:
51.1 - Aug 15
Tracking Status
firefox51 --- fixed

People

(Reporter: tromey, Assigned: tromey)

References

Details

(Whiteboard: [reserve-html])

Attachments

(1 file)

Currently builtin-modules.js defines a "CSS" module that resolves to CSS.
However, it would be more webby if it just defined this as a global.
Iteration: --- → 51.1 - Aug 15
Flags: qe-verify-
Priority: -- → P1
Whiteboard: [devtools-html] → [reserve-html]
Blocks: 1278625
Comment on attachment 8778274 [details]
Bug 1292574 - make CSS a global rather than a module in devtools loader;

https://reviewboard.mozilla.org/r/69600/#review66768

LGTM!
Attachment #8778274 - Flags: review?(gtatum) → review+
Pushed by ttromey@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/c2c4aa271822
make CSS a global rather than a module in devtools loader; r=gregtatum
https://hg.mozilla.org/mozilla-central/rev/c2c4aa271822
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 51
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.