1292591 - use mozilla/reject-some-requires rule in devtools/client/sourceeditor/

Status: RESOLVED FIXED

(DevTools :: Framework, enhancement, P1)

Description

[Tom Tromey :tromey]

We should use the mozilla/reject-some-requires eslint rule in
devtools/client/sourceeditor/ in order to ensure its continuing
"content-ready" cleanliness.

Comment 1

[Tom Tromey :tromey]

Attachment: Bug 1292591 - use reject-some-requires eslint rule in sourceeditor;

Review commit: https://reviewboard.mozilla.org/r/69612/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/69612/

Comment 2

[Greg Tatum [:gregtatum]]

Comment on attachment 8778300 [details]
Bug 1292591 - use reject-some-requires eslint rule in sourceeditor;

https://reviewboard.mozilla.org/r/69612/#review66764

Thanks for doing this!

::: devtools/client/sourceeditor/css-autocompleter.js:61
(Diff revision 1)
>  
>  // Autocompletion types.
>  
>  const CSS_STATES = {
>    "null": "null",
> -  property: "property",    // foo { bar|: … }
> +  // foo { bar|: … }

Can we disable the inline comment for the STATES? This really hurts readability. I'd prefer to disable the rule and have more readable code.

::: devtools/client/sourceeditor/debugger.js:336
(Diff revision 1)
>    setBreakpointCondition, removeBreakpointCondition, getBreakpoints, removeBreakpoints,
>    setDebugLocation, getDebugLocation, clearDebugLocation, find, findNext,
>    findPrev
> -].forEach(func => module.exports[func.name] = func);
> +].forEach(func => {
> +  module.exports[func.name] = func;
> +  return func;

Array.prototype.forEach won't do anything with returned values, so the return should probably be removed.

Comment 3

[Tom Tromey :tromey]

Comment on attachment 8778300 [details]
Bug 1292591 - use reject-some-requires eslint rule in sourceeditor;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/69612/diff/1-2/

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2a23e8874154
use reject-some-requires eslint rule in sourceeditor; r=gregtatum

Comment 5

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/2a23e8874154