1292649 - |mach bootstrap| fails for mobile/android on Debian: package openjdk-7 needs to be upgraded to openjdk-8

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Nick Alexander :nalexander [he/him]]

Looks like Open JDK 8 is the new normal: see also Bug 1267097.

User WalkingIce reports (edited):

"I tried use mozboot to build Fennec on my laptop, but I got a dependency package problem from build. The mozboot try to check openjdk-7[2] but which is removed from Debian testing[3].

I did a workaround by download mozboot and remove that line. It works and I built runnable Fennec. Maybe there are some people also have this kind of problem, so I try writing this mail to you to report this situation.

[2] https://github.com/mozilla/gecko-dev/blob/master/python/mozboot/mozboot/debian.py#L77

[3] https://tracker.debian.org/pkg/openjdk-7"

It looks like Android SDK 24 requires Java 8 now, so I guess the real solution is to update more generally.  This ticket tracks updating, probably around

https://dxr.mozilla.org/mozilla-central/source/python/mozboot/mozboot/archlinux.py#69

and

https://dxr.mozilla.org/mozilla-central/source/python/mozboot/mozboot/debian.py#77

Comment 1

[Julian Chu [:walkingice]]

Attachment: Upgrade openjdk version to 8 for debian

I tried upgrading version to java8 and it looks no problem to build fennec. Prepared this patch for your reference.

Comment 2

[Julian Chu [:walkingice]]

Attachment: Bug 1292649 - upgrade openjdk version to 8 for debian

mach bootstrap fails for mobile/android on Debian.

openjdk7-jdk was remove from Debian testing/unstable since 2016 Apr.
It was superseded by openjdk-8.

Review commit: https://reviewboard.mozilla.org/r/71434/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/71434/

Comment 3

[Julian Chu [:walkingice]]

Hi Nick,

I just tried submit a review request to mozreivew. I greatly appreciate for correcting me if I made any mistake.

Comment 4

[Mike Hommey [:glandium]]

Well, this results in breaking mach bootstrap on Debian stable and versions of Debian-based distros that don't have openjdk-8 yet...

Comment 5

[Julian Chu [:walkingice]]

I checked openjdk-8 exists in debian stable. Or I misunderstand anything?
https://tracker.debian.org/pkg/openjdk-8

Comment 6

[Mike Hommey [:glandium]]

That says it's in stable-bpo (backports), not stable. Which means apt-get install openjdk-8 doesn't work without adding the backports repository. Adding the backports repository is not something to do lightly.

Comment 7

[Julian Chu [:walkingice]]

Thank you Mike for explain the detail. I've discarded the review request and will try to understand more detail of it.

Comment 8

[Julian Chu [:walkingice]]

Comment on attachment 8779769 [details]
Upgrade openjdk version to 8 for debian

This patch has problem and is obsolete.

Comment 9

[Julian Chu [:walkingice]]

Install package "default-jdk" might be better than specified-version-jdk package.

For debian-testing/unstable it installs openjdk8, for debian-stable it install openjdk7. for debian-oldstable it install openjdk7 (if arch is amd64/i386).

I think it should be safe to use?

Comment 11

[Sylvestre Ledru [:Sylvestre]]

Attachment: Bug 1292649 - Use default-jdk instead of an explicit version of the jdk

Should be pretty safe as Java compa is usually very good.
This will fix the issue on Debian testing not having openjdk-7-jdk and
current Debian stable having it.
(same with Ubuntu)

Review commit: https://reviewboard.mozilla.org/r/101398/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/101398/

Comment 12

[Sylvestre Ledru [:Sylvestre]]

As a former maintainer of the Debian/Ubuntu default-java packages, I think using it is safe.

Comment 13

[Nick Alexander :nalexander [he/him]]

Comment on attachment 8822486 [details]
Bug 1292649 - Use default-jdk instead of an explicit version of the jdk

https://reviewboard.mozilla.org/r/101398/#review101976

If it works for you, it works for me.

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bdb654a6ce29
Use default-jdk instead of an explicit version of the jdk r=nalexander

Comment 15

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/bdb654a6ce29

Comment 16

[Julian Chu [:walkingice]]

I really appreciate this patch then I can build code on my Debian laptop :D