Closed Bug 1292649 Opened 5 years ago Closed 5 years ago

|mach bootstrap| fails for mobile/android on Debian: package openjdk-7 needs to be upgraded to openjdk-8

Categories

(Firefox Build System :: General, defect)

defect
Not set
normal

Tracking

(firefox53 fixed)

RESOLVED FIXED
mozilla53
Tracking Status
firefox53 --- fixed

People

(Reporter: nalexander, Assigned: Sylvestre)

References

Details

Attachments

(1 file, 2 obsolete files)

Looks like Open JDK 8 is the new normal: see also Bug 1267097.

User WalkingIce reports (edited):

"I tried use mozboot to build Fennec on my laptop, but I got a dependency package problem from build. The mozboot try to check openjdk-7[2] but which is removed from Debian testing[3].

I did a workaround by download mozboot and remove that line. It works and I built runnable Fennec. Maybe there are some people also have this kind of problem, so I try writing this mail to you to report this situation.

[2] https://github.com/mozilla/gecko-dev/blob/master/python/mozboot/mozboot/debian.py#L77

[3] https://tracker.debian.org/pkg/openjdk-7"

It looks like Android SDK 24 requires Java 8 now, so I guess the real solution is to update more generally.  This ticket tracks updating, probably around

https://dxr.mozilla.org/mozilla-central/source/python/mozboot/mozboot/archlinux.py#69

and

https://dxr.mozilla.org/mozilla-central/source/python/mozboot/mozboot/debian.py#77
I tried upgrading version to java8 and it looks no problem to build fennec. Prepared this patch for your reference.
Attachment #8779769 - Flags: review?(nalexander)
Hi Nick,

I just tried submit a review request to mozreivew. I greatly appreciate for correcting me if I made any mistake.
Well, this results in breaking mach bootstrap on Debian stable and versions of Debian-based distros that don't have openjdk-8 yet...
I checked openjdk-8 exists in debian stable. Or I misunderstand anything?
https://tracker.debian.org/pkg/openjdk-8
That says it's in stable-bpo (backports), not stable. Which means apt-get install openjdk-8 doesn't work without adding the backports repository. Adding the backports repository is not something to do lightly.
Attachment #8780840 - Attachment is obsolete: true
Attachment #8780840 - Flags: review?(nalexander)
Thank you Mike for explain the detail. I've discarded the review request and will try to understand more detail of it.
Comment on attachment 8779769 [details]
Upgrade openjdk version to 8 for debian

This patch has problem and is obsolete.
Attachment #8779769 - Attachment is obsolete: true
Attachment #8779769 - Attachment is patch: false
Attachment #8779769 - Flags: review?(nalexander)
Install package "default-jdk" might be better than specified-version-jdk package.

For debian-testing/unstable it installs openjdk8, for debian-stable it install openjdk7. for debian-oldstable it install openjdk7 (if arch is amd64/i386).

I think it should be safe to use?
Duplicate of this bug: 1267097
As a former maintainer of the Debian/Ubuntu default-java packages, I think using it is safe.
Assignee: nobody → sledru
Comment on attachment 8822486 [details]
Bug 1292649 - Use default-jdk instead of an explicit version of the jdk

https://reviewboard.mozilla.org/r/101398/#review101976

If it works for you, it works for me.
Attachment #8822486 - Flags: review+
Attachment #8822486 - Flags: review?(mh+mozilla)
Pushed by sledru@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/bdb654a6ce29
Use default-jdk instead of an explicit version of the jdk r=nalexander
https://hg.mozilla.org/mozilla-central/rev/bdb654a6ce29
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
I really appreciate this patch then I can build code on my Debian laptop :D
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.