Autoclassify breaks if you click on, away from, then back to a job with no parsed results

RESOLVED FIXED

Status

Tree Management
Treeherder
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: philor, Assigned: jgraham)

Tracking

Details

Attachments

(1 attachment)

(Reporter)

Description

2 years ago
And oddly enough, I do that consistently enough to have spotted it right off.

STR:

1. Load https://treeherder.allizom.org/#/jobs?repo=mozilla-inbound&revision=ab210b9e2172519fb1fc05a7a45af83ac6380032&autoclassify

2. In the "Windows 8 x64 opt" row click on the red TC[tier 2](B) job, the autoclassify panel will say "Logs not fully parsed, please wait" and you can click over to the Failure summary panel and see that what it instead means is "Log parsing failed. Unable to generate failure summary".

(This may well be the place to fix this bug, by making it impossible to get to the next state.)

3. In the same row, click on the orange M-e10s(bc4), getting a working autoclassify panel, then click back on the red TC[tier 2](B).

Expected: either admit that there's nothing parsed, or at least continue with the lie of "not fully parsed" like on the first click on it

Actual: panel shows a throbber, not possible to switch to other panels for that job, and that job stays in that same unswitchable permathrobber state until the tab is reloaded.

Curiously, the change from "Logs not fully parsed, please wait" to permathrobber applies to all such jobs: that revision has four (or more, I'm still retriggering) red Windows TC builds, and after a reload you can click on all four of them and get "not fully parsed" for all of them, until you click on a parsed job and then back onto any one of the four, at which point all four will switch to permathrobber.

Also curiously (though I can't give you an example that will stay unstarred since apparently Autophone isn't submitting to allizom), an Autophone job with a perfectly good parsed result will do the same thing.
This issue is apparently meaning everyone in the "on by default" group has been using &noautoclassify for months. 

Could you revert the default for now?
Flags: needinfo?(james)
(Assignee)

Comment 2

2 years ago
Do we have a recent example of a broken log that triggers this? I have found *a* bug but I don't know if it's *the* bug.
Created attachment 8796550 [details] [review]
[treeherder] mozilla:text_log_summary_load > mozilla:master
(Assignee)

Updated

2 years ago
Attachment #8796550 - Flags: review?(wlachance)
Comment on attachment 8796550 [details] [review]
[treeherder] mozilla:text_log_summary_load > mozilla:master

r+ to the fix but I feel like the code needs some reworking unless I'm missing something.
Attachment #8796550 - Flags: review?(wlachance) → review+

Comment 5

2 years ago
Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/c54c4c2e36d6bd51c3ba63dcd11205660340263d
Bug 1292910 - Fix handling of text log summary model load errors in autoclassify panel (#1885)
Assignee: nobody → james
Status: NEW → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
(Assignee)

Updated

2 years ago
Flags: needinfo?(james)
You need to log in before you can comment on or make changes to this bug.